Diffusion Phorge (master) History

phorge/src/infrastructure/diff
master

Oct 24 2024

5f4587bb88dd Fix implicitly nullable parameter declarations for PHP 8.4
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Sep 9 2024

aa2b70708e2f PHPDoc: Replace "@return this" with "@return $this"
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Aug 21 2024

b44b566b1334 Add missing variable names to PHPDoc @param of methods
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jun 7 2024

d2bca2f32da0 Fix call to non-existing getTransactionCommentForSave() in…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jun 2 2023

dd24c94b0741 Fix PHP 8.1 "strlen(null)" exceptions block creating a diff in Differential web…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Apr 20 2022

2188473fa772 Fix an issue where we may "min()" an empty array when viewing a revision with…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 29 2021

1308a5555fee Update client logic for inline comment "Save" and "Cancel" actions
Author
epriestley
Browse Repository
No Builds
No Audits

6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Browse Repository
No Builds
No Audits

428fff2e58f3 Fix an issue when undoing mutiple inline comment deletions
Author
epriestley
Browse Repository
No Builds
No Audits

d30c3a961cd9 Make the client authoritative for "Cancel" actions
Author
epriestley
Browse Repository
No Builds
No Audits

60e869f4114f Make the client authoritative for "Save" actions
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 19 2020

bc4f86d27996 When a new, deleted, draft inline is revived with "Undo", undelete it
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 16 2020

2b8bbae5fb27 Set an explicit height when drawing the dependent revision graph
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 2 2020

0f27cd46ccad Never render "Show More Context" inside an inline comment suggestion diff
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 12 2020

9fa25253844e Improve rendering of history graph in "CommitGraphView"
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 5 2020

ce0dc9a2ba2c Correct an apparent off-by-one error when adjusting inlines across revision…
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 23 2020

fcb75d0503c6 Fix an issue where prose diffing may fail after hitting the PCRE backtracking…
Author
epriestley
Browse Repository
No Builds
No Audits

May 30 2020

36075f6ce525 Correct a prose diff behavior when prose pieces include newlines
Author
epriestley
Browse Repository
No Builds
No Audits

May 20 2020

6d0dbeb77f77 Use the changeset parse cache to cache suggestion changesets
Author
epriestley
Browse Repository
No Builds
No Audits

5d0ae283a9ab Put a readthrough cache in front of inline context construction
Author
epriestley
Browse Repository
No Builds
No Audits

d2d7e7f5ff1b Clean up Diffusion behaviors for inline edit suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Browse Repository
No Builds
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Browse Repository
No Builds
No Audits

87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Browse Repository
No Builds
No Audits

May 14 2020

fbd57ad83232 Give selected inline comments are more obvious selected state
Author
epriestley
Browse Repository
No Builds
No Audits

May 13 2020

2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Browse Repository
No Builds
No Audits

c063e0e5ec9d Add "View Raw Remarkup" to inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

419b7ceebb0f Move inline comment actions into a dropdown menu
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2020

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Browse Repository
No Builds
No Audits

May 8 2020

b804e8cffad2 Make "View" from inline comment previews correctly jump to "isEditing" inlines
Author
epriestley
Browse Repository
No Builds
No Audits

fa2d30ee3698 Lift inline comment draft behaviors to "InlineController"
Author
epriestley
Browse Repository
No Builds
No Audits

May 7 2020

94a95efa059a Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

79107574a762 Remove "DifferentialInlineCommentQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

983d77848b4c Move the "Inline List" view to "DiffInlineCommentQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

af5b94b23473 Lift most "InlineController" querying to the base class
Author
epriestley
Browse Repository
No Builds
No Audits

d0593a5a788e Replace "loadDraftAndPublishedComments()" with a Query
Author
epriestley
Browse Repository
No Builds
No Audits

c1f1345cc053 Make InlineCommentQueries more robust/consistent
Author
epriestley
Browse Repository
No Builds
No Audits

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Browse Repository
No Builds
No Audits

May 6 2020

0067f1a521a0 Remove the obsolete "DiffusionInlineCommentPreviewController"
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

a590db28b254 Fix an issue where non-ID changeset state keys were used as changeset IDs
Author
epriestley
Browse Repository
No Builds
No Audits

07e160bde1e8 When cancelling an unsaved editing inline after a reload, don't cancel into an…
Author
epriestley
Browse Repository
No Builds
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Browse Repository
No Builds
No Audits

63bfad0ff476 Refine unusual inline comment client interactions
Author
epriestley
Browse Repository
No Builds
No Audits

b2ce0844b6ff When a user clicks "Cancel" on an inline comment to leave the "Editing" state…
Author
epriestley
Browse Repository
No Builds
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 29 2020

186a12ef7f2a Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 19 2020

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Browse Repository
No Builds
No Audits

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 12 2020

f9b3e3360b0c Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 30 2019

76d9912932bc Force unified abstract block diffs into roughly usable shape
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 25 2019

884cd74cc4a5 In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
Author
epriestley
Browse Repository
No Builds
No Audits

9d884f144f01 Add "PhutilProseDiff" classes to "phabricator/"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 30 2019

6d13b9fb7a26 Make very minor generality improvements to the scope selector
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 20 2019

f1a035d5c2c6 In Differential, give the "moved/copied from" gutter a more clear visual look
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 19 2019

98fe8fae4a90 Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Author
epriestley
Browse Repository
No Builds
No Audits

3f8eccdaec8f Put some whitespace behaviors back, but only for "diff alignment", not display
Author
epriestley
Browse Repository
No Builds
No Audits

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Browse Repository
No Builds
No Audits

92abe3c8fb84 Extract scope line selection logic from the diff rendering engine so it can…
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 7 2018

2a03367a50c0 When authors add inlines to their own revisions/commits, mark them as "Done" by…
Author
epriestley
Browse Repository
No Builds
No Audits

16a6fc8341ea Allow reviewers to mark their own inlines as "Done" before they submit them
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 6 2018

650e74933abb Update some inline comment logic to use more modern "Viewer"-oriented…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 17 2018

438edde03150 Add some missing aural button labels for accessibility
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 7 2018

7acda7e94e60 Truncate package names in diff table of contents views
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
Dmitri Iouchtchenko
Browse Repository
No Builds
No Audits

Jun 15 2017

3be36783b377 Consider inline comments with draft checkmarks as "unsubmitted"
Author
epriestley
Browse Repository
No Builds
No Audits

887bd2d66ef0 In the UI, rename "Hide Inline" to "Collapse Inline"
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 13 2017

21d16c723613 Fix cancel button on inline comment view
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 12 2017

283a95d2aae0 Build a page for viewing all inline comments
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 7 2017

8692d673c8ab Fix minor inline comment header button behaviors
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2017

00400ae6f965 Search and Replace calls to setShade
Author
Chad Little
Browse Repository
No Builds
No Audits

May 20 2017

4dff754502bd Show a snippet when hovering inlines in the objective list
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2017

6c46f27d98c4 Add quest objectives to the minimap
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2017

6a9dd61c427b Make collapsed inlines more useful and anchor target highlights more accurate
Author
epriestley
Browse Repository
No Builds
No Audits

86b9deb8a9e9 Move inline anchors up, to dolumn-level
Author
epriestley
Browse Repository
No Builds
No Audits

8052ab84bfd8 Remove "^" (Prev) and "V" (Next) actions on Differential inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

41379f39debb Move inline replies to new code and remove DifferentialInlineEditor
Author
epriestley
Browse Repository
No Builds
No Audits

3c18cb77fb66 Move inline "done" checkboxing to DiffInline
Author
epriestley
Browse Repository
No Builds
No Audits

4fd4ec3d275d Hide inlines one-by-one, instead of in a big group
Author
epriestley
Browse Repository
No Builds
No Audits

63450cc48eca Remove "Show All Context" button from Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 19 2017

f8cebdc418e8 Make Differential inline events actually trigger comment preview refreshes
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 17 2017

48187cdbbe99 Fix an unusual nonterminating task graph node
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 11 2017

b5722a99635a Use EditEngine stacked comments in Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 2 2017

00313094d3ab Make "View" links on Differential inline comment previews work again
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 31 2016

18249b097fb6 Make inline comment preview and submission mostly work on EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 1 2016

7b5e84282fc6 Improve "thread" rendering of unusually-shaped graphs
Author
epriestley
Browse Repository
No Builds
No Audits

0a132e468fc4 Render parent and child tasks in Maniphest with a graph trace
Author
epriestley
Browse Repository
No Builds
No Audits

dc37789d530f Build that thing someone posted a screenshot of on Facebook
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 30 2016

6c7e392f8936 Merge "Table of Contents", "Local Commits", "Update History" and "Similar…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 12 2016

148a50e48be1 Convert Differential to new layout
Author
Chad Little
Browse Repository
No Builds
No Audits

Mar 10 2016

68b468a846c1 Partially improve threading UI for adjacent inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

8858b6cf8d17 When replying to a ghost comment, attach the reply to the same place
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 6 2016

aaab1011e5a4 Give AphrontTagView a `getViewer()`, deprecate `getUser()`
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 29 2016

41262150dfb5 Remove unused call to phui-text
Author
Chad Little
Browse Repository
No Builds
No Audits

Jan 27 2016

36158dbdc081 Convert all calls to 'IconFont' to just 'Icon'
Author
Chad Little
Browse Repository
No Builds
No Audits

Nov 15 2015

1f1c3f40755e Allow lint messages to be rendered as Remarkup
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Sep 10 2015

4e181a5611fb Clean up browse/history links in Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits