HomePhorge

Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"

Description

Replace nonexistent "withPHIDs()" in ChangesetQuery with "withIDs()"

Summary:
Ref T13519. See https://discourse.phabricator-community.org/t/error-call-to-undefined-method-differentialchangesetquery-withphids/3816/.

Changesets do not have PHIDs, and the Query has no "withPHIDs()" method. The keys in the viewstate storage are (usually) IDs.

Test Plan:

  • On a revision with Diff 1 and Diff 2 affecting the same file:
    • Viewed Diff 1.
    • Hid file A.
    • Viewed Diff 2.
  • Before patch: exception about call to "withPHIDs()", which does not exist for ChangesetQuery.
  • After patch: no exception. Also, file actually unhid, which is the correct behavior!

Maniphest Tasks: T13519

Differential Revision: https://secure.phabricator.com/D21189

Details

Provenance
epriestleyAuthored on Apr 29 2020, 2:41 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPb648a8584111: Fix an issue where the Maniphest burnup chart was trying to render a non-View…
Branches
Unknown
Tags
Unknown

Event Timeline