HomePhorge

Improve "thread" rendering of unusually-shaped graphs

Description

Improve "thread" rendering of unusually-shaped graphs

Summary:
Ref T4788. This fixes all the bugs I was immediately able to catch:

  • "Directory-Like" graph shapes could draw too many vertical lines.
  • "Reverse-Directory-Like" graph shapes could draw too few vertical lines.
  • Terminated, branched graph shapes drew the very last line to the wrong place.

This covers the behavior with tests, so we should be able to fix more stuff later without breaking anything.

Test Plan:

  • Added failing tests and made them pass.

{F1708158}

{F1708159}

{F1708160}

{F1708161}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4788

Differential Revision: https://secure.phabricator.com/D16216

Details

Provenance
epriestleyAuthored on Jul 1 2016, 9:22 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP0a132e468fc4: Render parent and child tasks in Maniphest with a graph trace
Branches
Unknown
Tags
Unknown

Event Timeline