HomePhorge

When creating an inline comment, populate the content state with the default…

Description

When creating an inline comment, populate the content state with the default suggestion text

Summary:
Ref T13559. Currently, the default text for inline comment side-loads in a bizarre way. Instead, when a user creates an inline comment, load the inline context and set it as part of the initial content state.

This allows the side channel (and the code that puts the text in place at the last second on the client) to be removed.

Test Plan: Created inlines, clicked "Suggest Edit". See followup changes.

Maniphest Tasks: T13559

Differential Revision: https://secure.phabricator.com/D21652

Details

Provenance
epriestleyAuthored on Mar 25 2021, 10:55 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP5efe7fb4c181: On inline comments, track an explicit "committed" content state
Branches
Unknown
Tags
Unknown

Event Timeline