HomePhorge

Allow inline comment storage objects to generate their own runtime objects

Description

Allow inline comment storage objects to generate their own runtime objects

Summary:
Ref T13513. Currently, inline storage objects ("TransactionComment") can't directly generate a runtime object ("InlineComment").

Allow this transformation to be performed in a genric way so clunky code which does it per-object-type can be removed, lifted, or simplified.

Simplify an especially gross callsite in preview code.

Test Plan: Previewed inline comments.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21226

Details

Provenance
epriestleyAuthored on May 7 2020, 8:42 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP397648855f8b: Make the "attach_inlines" parameter to "differential.createcomment" a no-op
Branches
Unknown
Tags
Unknown

Event Timeline