HomePhorge

Make the client authoritative for "Save" actions

Description

Make the client authoritative for "Save" actions

Summary:
Ref T13559. When you click "Save" on an inline comment and it's empty, we may actually delete the comment.

Currently, the client and server both make decisions about whether the comment should be deleted. These decisions may not agree, causing the client state to fall out of sync.

Make the client authoritative about whether it wants to handle the user clicking the "Save" button as an intent to save or an intent to delete.

Test Plan: Saved empty and nonempty inlines. See followup changes.

Maniphest Tasks: T13559

Differential Revision: https://secure.phabricator.com/D21648

Details

Provenance
epriestleyAuthored on Mar 23 2021, 12:24 PM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP0f04d9e58458: Remove direct reads of form state from main Inline client code
Branches
Unknown
Tags
Unknown

Event Timeline