HomePhorge

Replace "loadDraftAndPublishedComments()" with a Query

Description

Replace "loadDraftAndPublishedComments()" with a Query

Summary: Ref T13513. Continue marching toward coherent query pathways for all access to inline comments.

Test Plan:

  • Viewed a commit and a path within that commit, as a user with unpublished inlines and a different user.
  • Saw appropriate inlines in all cases (published inlines, plus undeleted unpublished inlines authored by the current viewer).
  • Grepped for "loadDraftAndPublishedComments()".

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21228

Details

Provenance
epriestleyAuthored on May 7 2020, 11:24 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPc1f1345cc053: Make InlineCommentQueries more robust/consistent
Branches
Unknown
Tags
Unknown

Event Timeline