Diffusion Phorge (HEAD -> master) History

phorge/webroot/rsrc/js/application/diff
HEAD -> masterf3d49f740737d31dd940c62…

Mar 29 2021

1308a5555fee Update client logic for inline comment "Save" and "Cancel" actions
Author
epriestley
Browse Repository
No Builds
No Audits

6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Browse Repository
No Builds
No Audits

5efe7fb4c181 On inline comments, track an explicit "committed" content state
Author
epriestley
Browse Repository
No Builds
No Audits

d30c3a961cd9 Make the client authoritative for "Cancel" actions
Author
epriestley
Browse Repository
No Builds
No Audits

60e869f4114f Make the client authoritative for "Save" actions
Author
epriestley
Browse Repository
No Builds
No Audits

0f04d9e58458 Remove direct reads of form state from main Inline client code
Author
epriestley
Browse Repository
No Builds
No Audits

cb00cb99e244 Make client inlines track an "active" state
Author
epriestley
Browse Repository
No Builds
No Audits

b964731b6a6b Make inline "ContentState" a client object, and track "hasSuggestion" on it
Author
epriestley
Browse Repository
No Builds
No Audits

87c6c270b435 Fix an issue where inlines could be duplicated in the client list
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 2 2020

0f0e94ca71fe Use "getInlines()", not "_inlines", to access inlines on client Changeset…
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2020

3635a11f848f When cancelling an edit of an inline with content, don't hide the inline
Author
epriestley
Browse Repository
No Builds
No Audits

May 21 2020

87fb35abb72e Prevent keyboard selection of change blocks inside edit suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

66566f878d82 Make "Open in Editor" use the simple line number of the current selected block
Author
epriestley
Browse Repository
No Builds
No Audits

May 20 2020

d2d7e7f5ff1b Clean up Diffusion behaviors for inline edit suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Browse Repository
No Builds
No Audits

87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2020

770a5c8412d1 Fix "r" and "R" both replying with quote on inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

May 15 2020

93b08f0e83e6 Fix an out-of-order access issue with inlines
Author
epriestley
Browse Repository
No Builds
No Audits

e959f934893c Use a more consistent inline highlighting style with fewer redraws
Author
epriestley
Browse Repository
No Builds
No Audits

c666cb9f0bc7 Reduce the frequency of DOM scans to rebuild inlines when scrolling revisions
Author
epriestley
Browse Repository
No Builds
No Audits

May 14 2020

3ee6b5393c77 Improve offset/range inline behavior for rich diffs and unified diffs
Author
epriestley
Browse Repository
No Builds
No Audits

fbd57ad83232 Give selected inline comments are more obvious selected state
Author
epriestley
Browse Repository
No Builds
No Audits

b021da71a52d When users click headers to select diff UI elements, don't eat the events
Author
epriestley
Browse Repository
No Builds
No Audits

f45519c0604b When cancelling an inline comment edit, exit the edit state after the response…
Author
epriestley
Browse Repository
No Builds
No Audits

cfb5de6fa77f Distinguish more carefully between "null" inline offsets and "0" inline offsets
Author
epriestley
Browse Repository
No Builds
No Audits

May 13 2020

2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Browse Repository
No Builds
No Audits

ebef22ccc1bb Improve select-to-comment behavior in Firefox and on unified diffs
Author
epriestley
Browse Repository
No Builds
No Audits

42378ea393fe Allow users to create inline comments by directly selecting text directly
Author
epriestley
Browse Repository
No Builds
No Audits

c063e0e5ec9d Add "View Raw Remarkup" to inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

419b7ceebb0f Move inline comment actions into a dropdown menu
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2020

acc1fa165519 Make "View as Document Type..." only show valid options
Author
epriestley
Browse Repository
No Builds
No Audits

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Browse Repository
No Builds
No Audits

May 8 2020

e7ebd5d9d1f8 Make "Delete" from inline comment previews function correctly while editing…
Author
epriestley
Browse Repository
No Builds
No Audits

b804e8cffad2 Make "View" from inline comment previews correctly jump to "isEditing" inlines
Author
epriestley
Browse Repository
No Builds
No Audits

24ba66f106f2 Persist "Show Changeset" and improve path text selection
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

07e160bde1e8 When cancelling an unsaved editing inline after a reload, don't cancel into an…
Author
epriestley
Browse Repository
No Builds
No Audits

3a76248071eb When loading a page with inlines, don't select/focus inlines which we…
Author
epriestley
Browse Repository
No Builds
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Browse Repository
No Builds
No Audits

63bfad0ff476 Refine unusual inline comment client interactions
Author
epriestley
Browse Repository
No Builds
No Audits

b2ce0844b6ff When a user clicks "Cancel" on an inline comment to leave the "Editing" state…
Author
epriestley
Browse Repository
No Builds
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 23 2020

d2572f8b335a Refine more Differential review state behaviors
Author
epriestley
Browse Repository
No Builds
No Audits

0ede616f314b Update the "View Options" menu for recent filetree changes
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 22 2020

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

ff88eb588eb4 Show change information in file icons in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

9550ae69849c When a directory has a single directory child, collapse them into a single…
Author
epriestley
Browse Repository
No Builds
No Audits

12eddb18fb78 Entirely replace the old filetree UI with the "flank" UI
Author
epriestley
Browse Repository
No Builds
No Audits

ba8071bbef50 Roughly style the new "flank" paths UI
Author
epriestley
Browse Repository
No Builds
No Audits

8cd1f9a30976 Generate file trees from changesets in the new flank UI
Author
epriestley
Browse Repository
No Builds
No Audits

646280972b88 Glue the new FormationView on top of the older Filetree view in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 19 2020

537ff68edda2 In Differential, make the "Open in Editor" keystroke work with no selection, or…
Author
epriestley
Browse Repository
No Builds
No Audits

8bdc7133521d Make the "Keyboard Shortcuts" dialog in Differential less hideous
Author
epriestley
Browse Repository
No Builds
No Audits

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 17 2020

3d966d8a41f1 Add an "Open in External Editor" keystroke to Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 25 2019

2c06815edb0f When rendering Jupyter notebook diffs, split code inputs into individual blocks
Author
epriestley
Browse Repository
No Builds
No Audits

932d829af339 Improve behavior of inline comment highlight reticle for block diffs
Author
epriestley
Browse Repository
No Builds
No Audits

7ae711ed3e0b Add a "View as..." option to diff dropdowns for selecting between document…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 19 2019

efccd75ae371 Correct various minor diff copy behaviors
Author
epriestley
Browse Repository
No Builds
No Audits

98fe8fae4a90 Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Author
epriestley
Browse Repository
No Builds
No Audits

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 26 2018

8b550ce2cd8f Don't allow the middle mouse button to start an inline comment
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 17 2018

75a5dd8d8cc0 Add more accessibility labels for screen readers
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 13 2018

e5906f4e127e In Differential standalone views, disable some keyboard shortcuts which don't…
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 7 2018

7729c51cc4f2 Fix an issue where scrolling down, then up, then down fails to show changeset…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 14 2018

a4053bb5808e When a ChangesetList sleeps after a Quicksand navigation, also hide any visible…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 8 2018

261a4a0e51fd Add inline comment counts to the filetree view
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 15 2017

3700bcb638de Warn and prevent 1-up/2-up switch in Differential if the user is editing an…
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 25 2017

c217d7619c5f Make "A" hide or show all inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 21 2017

0d8f4170f4dc Fix an issue when deleting the entire content of an unsubmitted inline comment
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 12 2017

565c49ad0ee8 Minor touchup on diff banner
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 15 2017

9b93697d52f4 Move "List Inline Comments" to the inline header dropdown menu
Author
epriestley
Browse Repository
No Builds
No Audits

b3b30dde6ac9 Add options for hidding inlines to the Differential header banner
Author
epriestley
Browse Repository
No Builds
No Audits

3be36783b377 Consider inline comments with draft checkmarks as "unsubmitted"
Author
epriestley
Browse Repository
No Builds
No Audits

887bd2d66ef0 In the UI, rename "Hide Inline" to "Collapse Inline"
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 7 2017

8692d673c8ab Fix minor inline comment header button behaviors
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 5 2017

9773dc0e6cc4 Add "X / Y Comments" button to Differential persistent header
Author
epriestley
Browse Repository
No Builds
No Audits

863b7ab76685 Add an "Unsubmitted" button to the Differential persistent header
Author
epriestley
Browse Repository
No Builds
No Audits

48c6ca40c44f Add an "Unsaved" button to the Differential persistent header
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 1 2017

b66bf6af9267 When stabilizing document scroll position for diffs, stick to anchors harder
Author
epriestley
Browse Repository
No Builds
No Audits

May 30 2017

83e99fb691aa Add a class to the Differential banner when unsubmitted/unsaved changes are…
Author
epriestley
Browse Repository
No Builds
No Audits

cc0a6fd3aa45 Remove the ability to leave multi-line inline comments on touchscreen devices
Author
epriestley
Browse Repository
No Builds
No Audits

d20221dc7d82 Remove Differential "objectives" UI
Author
epriestley
Browse Repository
No Builds
No Audits

d161a07781e0 Improve Differential behavior when scrolling with anchors
Author
epriestley
Browse Repository
No Builds
No Audits

May 20 2017

7d44e7cb4d2f Show the curent selected inline in the objective list
Author
epriestley
Browse Repository
No Builds
No Audits

e15009b76e1b Show "reply" inlines as replies in the objective list
Author
epriestley
Browse Repository
No Builds
No Audits

4dff754502bd Show a snippet when hovering inlines in the objective list
Author
epriestley
Browse Repository
No Builds
No Audits

7a40dd380ee7 When a user cancels a new inline, clear it from the objective list
Author
epriestley
Browse Repository
No Builds
No Audits

c056ff56cc95 Fix a diff objective issue where objectives could appear in the wrong place
Author
epriestley
Browse Repository
No Builds
No Audits

af07600aaac7 Make Differential objective markers show a brighter "editing" state
Author
epriestley
Browse Repository
No Builds
No Audits

8b2a06387dbc Stop long filenames in objective list tooltips from being cut off
Author
epriestley
Browse Repository
No Builds
No Audits

aba209e9990f Hide the Differential scroll objective list on trackpad systems
Author
epriestley
Browse Repository
No Builds
No Audits

bdecff7d67ce Show "objectives" UI only if prototypes are enabled
Author
epriestley
Browse Repository
No Builds
No Audits

6945e80feed5 For the diff banner, detect the current changeset better
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2017

fdf00f6df475 Clean up some minor UI behaviors in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

6c46f27d98c4 Add quest objectives to the minimap
Author
epriestley
Browse Repository
No Builds
No Audits

May 18 2017

fb9f3cc0b4ca Restore the "buoyant" header in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

f78ce156f114 Restore "h" to hide or show files, and modernize file visibility toggling
Author
epriestley
Browse Repository
No Builds
No Audits