HomePhorge

Improve select-to-comment behavior in Firefox and on unified diffs

Description

Improve select-to-comment behavior in Firefox and on unified diffs

Summary:
Ref T13513.

  • Firefox represents multiple selected rows as a discontinuous range. Accommodate this.
  • Unified diffs don't have a "copy" marker. Do something sort-of-reasonable for them.

Test Plan:

  • Selected multiple lines of content in Firefox, got an option to add a comment.
  • Selected content in unified mode, got an option to add a comment.

Maniphest Tasks: T13513

Differential Revision: https://secure.phabricator.com/D21249

Details

Provenance
epriestleyAuthored on May 13 2020, 1:37 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP42378ea393fe: Allow users to create inline comments by directly selecting text directly
Branches
Loading...
Tags
Loading...

Event Timeline