HomePhorge

Fix a diff objective issue where objectives could appear in the wrong place

Description

Fix a diff objective issue where objectives could appear in the wrong place

Summary:
Ref T12733. When creating a new comment, the objective could appear to far up in the scrollbar because we were anchoring it to an invisible row.

Instead, anchor to the "edit" row while editing.

Test Plan: Created a new comment at the very top of a file, saw "File, Star" icons instead of "Star, File".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12733

Differential Revision: https://secure.phabricator.com/D17978

Details

Provenance
epriestleyAuthored on May 20 2017, 5:26 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPaf07600aaac7: Make Differential objective markers show a brighter "editing" state
Branches
Unknown
Tags
Unknown

Event Timeline