HomePhorge

Use "getInlines()", not "_inlines", to access inlines on client Changeset…

Description

Use "getInlines()", not "_inlines", to access inlines on client Changeset objects

Summary:
See PHI1898. An install is reporting an execution/initialization order issue where this code is reachable before _inlines is initialized.

I can't immediately reproduce it, but using "getInlines()" is preferable anyway and seems likely to fix the problem.

Test Plan: Viewed revisions with inlines, added/removed/edited/replied to inlines, didn't find anything broken.

Differential Revision: https://secure.phabricator.com/D21475

Details

Provenance
epriestleyAuthored on Oct 2 2020, 9:09 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPa5f20f710669: When printing, wrap all content in Remarkup tables more aggressively
Branches
Unknown
Tags
Unknown

Event Timeline