Diffusion Phorge (master) History

phorge/src/infrastructure/diff/view
master6fd55d692f14c9bf8d658b1…

Mar 29 2021

6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Browse Repository
No Builds
No Audits

428fff2e58f3 Fix an issue when undoing mutiple inline comment deletions
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 16 2020

2b8bbae5fb27 Set an explicit height when drawing the dependent revision graph
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 2 2020

0f27cd46ccad Never render "Show More Context" inside an inline comment suggestion diff
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 12 2020

9fa25253844e Improve rendering of history graph in "CommitGraphView"
Author
epriestley
Browse Repository
No Builds
No Audits

May 20 2020

6d0dbeb77f77 Use the changeset parse cache to cache suggestion changesets
Author
epriestley
Browse Repository
No Builds
No Audits

10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Browse Repository
No Builds
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Browse Repository
No Builds
No Audits

87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Browse Repository
No Builds
No Audits

May 14 2020

fbd57ad83232 Give selected inline comments are more obvious selected state
Author
epriestley
Browse Repository
No Builds
No Audits

May 13 2020

2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Browse Repository
No Builds
No Audits

c063e0e5ec9d Add "View Raw Remarkup" to inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

419b7ceebb0f Move inline comment actions into a dropdown menu
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2020

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Browse Repository
No Builds
No Audits

May 8 2020

b804e8cffad2 Make "View" from inline comment previews correctly jump to "isEditing" inlines
Author
epriestley
Browse Repository
No Builds
No Audits

May 7 2020

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

07e160bde1e8 When cancelling an unsaved editing inline after a reload, don't cancel into an…
Author
epriestley
Browse Repository
No Builds
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Browse Repository
No Builds
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 30 2019

76d9912932bc Force unified abstract block diffs into roughly usable shape
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 20 2019

f1a035d5c2c6 In Differential, give the "moved/copied from" gutter a more clear visual look
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 19 2019

98fe8fae4a90 Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 7 2018

16a6fc8341ea Allow reviewers to mark their own inlines as "Done" before they submit them
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 17 2018

438edde03150 Add some missing aural button labels for accessibility
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 7 2018

7acda7e94e60 Truncate package names in diff table of contents views
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
Dmitri Iouchtchenko
Browse Repository
No Builds
No Audits

Jun 15 2017

3be36783b377 Consider inline comments with draft checkmarks as "unsubmitted"
Author
epriestley
Browse Repository
No Builds
No Audits

887bd2d66ef0 In the UI, rename "Hide Inline" to "Collapse Inline"
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 13 2017

21d16c723613 Fix cancel button on inline comment view
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 12 2017

283a95d2aae0 Build a page for viewing all inline comments
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 7 2017

8692d673c8ab Fix minor inline comment header button behaviors
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2017

00400ae6f965 Search and Replace calls to setShade
Author
Chad Little
Browse Repository
No Builds
No Audits

May 20 2017

4dff754502bd Show a snippet when hovering inlines in the objective list
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2017

6c46f27d98c4 Add quest objectives to the minimap
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2017

6a9dd61c427b Make collapsed inlines more useful and anchor target highlights more accurate
Author
epriestley
Browse Repository
No Builds
No Audits

86b9deb8a9e9 Move inline anchors up, to dolumn-level
Author
epriestley
Browse Repository
No Builds
No Audits

8052ab84bfd8 Remove "^" (Prev) and "V" (Next) actions on Differential inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

4fd4ec3d275d Hide inlines one-by-one, instead of in a big group
Author
epriestley
Browse Repository
No Builds
No Audits

63450cc48eca Remove "Show All Context" button from Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 19 2017

f8cebdc418e8 Make Differential inline events actually trigger comment preview refreshes
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 17 2017

48187cdbbe99 Fix an unusual nonterminating task graph node
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 11 2017

b5722a99635a Use EditEngine stacked comments in Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 2 2017

00313094d3ab Make "View" links on Differential inline comment previews work again
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 31 2016

18249b097fb6 Make inline comment preview and submission mostly work on EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 1 2016

7b5e84282fc6 Improve "thread" rendering of unusually-shaped graphs
Author
epriestley
Browse Repository
No Builds
No Audits

0a132e468fc4 Render parent and child tasks in Maniphest with a graph trace
Author
epriestley
Browse Repository
No Builds
No Audits

dc37789d530f Build that thing someone posted a screenshot of on Facebook
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 30 2016

6c7e392f8936 Merge "Table of Contents", "Local Commits", "Update History" and "Similar…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 12 2016

148a50e48be1 Convert Differential to new layout
Author
Chad Little
Browse Repository
No Builds
No Audits

Mar 10 2016

68b468a846c1 Partially improve threading UI for adjacent inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 6 2016

aaab1011e5a4 Give AphrontTagView a `getViewer()`, deprecate `getUser()`
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 29 2016

41262150dfb5 Remove unused call to phui-text
Author
Chad Little
Browse Repository
No Builds
No Audits

Jan 27 2016

36158dbdc081 Convert all calls to 'IconFont' to just 'Icon'
Author
Chad Little
Browse Repository
No Builds
No Audits

Nov 15 2015

1f1c3f40755e Allow lint messages to be rendered as Remarkup
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Sep 10 2015

4e181a5611fb Clean up browse/history links in Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 31 2015

51c52f50fdda Prevent users from hiding unpublished inlines
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 20 2015

9790f93a835e Show all packages with a claim on a file in the table of contents view
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 17 2015

6010e80e5c5a Show packages in table of contents views in Diffusion and Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 16 2015

cfd134897501 Fix an issue with Table of Contents construction for copied files
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 15 2015

8149399312b0 Convert commits to use unified table of contents
Author
epriestley
Browse Repository
No Builds
No Audits

cb912d17352c Convert DifferentialRevision view to new PHUIDiffTableOfContentsListView
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 1 2015

3b755115c2d8 [Redesgin] Misc Inline Comment tweaks
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 29 2015

6fef37ddb5b5 [Redesign] Update Inline Comment UI
Author
Chad Little
Browse Repository
No Builds
No Audits

May 31 2015

9708f68e585a Increase CSS specificity on Inline Comment Summary
Author
Chad Little
Browse Repository
No Builds
No Audits

May 27 2015

e9f4a84a892c Allow inline comments to be individually hidden
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2015

36e2d02d6ec5 phtize all the things
Author
Joshua Spence
Browse Repository
No Builds
No Audits

May 13 2015

61b178f44e48 Use PhutilInvalidStateException
Author
Joshua Spence
Browse Repository
No Builds
No Audits

May 4 2015

9c7d1b0b90b5 Highlight cell when jumping to an inline comment
Author
epriestley
Browse Repository
No Builds
No Audits

861155ea73ea Remove click to view on ghosties
Author
Chad Little
Browse Repository
No Builds
No Audits

May 1 2015

94299c0a6b19 Minor tweaks to inline comments
Author
Chad Little
Browse Repository
No Builds
No Audits

Apr 30 2015

68c113832e82 Collapse previous/forward by default, click to expand.
Author
Chad Little
Browse Repository
No Builds
No Audits

Apr 21 2015

fe774e68e255 Distinguish between ported-forward and ported-backward comments
Author
epriestley
Browse Repository
No Builds
No Audits

b2d280ff5142 Port comments through time and space in the common/best case
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 5 2015

ea376685ae9e Fix some odd looking arrays
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Apr 2 2015

638cdb8d5773 Don't show comment draft state to non-object-owners
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 27 2015

637974a1903b Polish up Done Button UI States
Author
Chad Little
Browse Repository
No Builds
No Audits

a17542ab28c2 Touch up PHP/JS interactions for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

b56001457785 Revamp inline commenting UI
Author
Chad Little
Browse Repository
No Builds
No Audits

174cf8239802 Provide getObjectOwnerPHID() on inline comment views
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 25 2015

1fd163d0976c Mostly provide CSS for "done" states
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 24 2015

4310c4ed5387 Track a "Done" state on inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 9 2015

f1f2c5d01df1 Reduce code duplication in inline right/left side tracking
Author
epriestley
Browse Repository
No Builds
No Audits

56a970900856 Reduce code duplication for inline "Undo"
Author
epriestley
Browse Repository
No Builds
No Audits

355142fcbf23 Reduce code duplication on comment editing UI
Author
epriestley
Browse Repository
No Builds
No Audits

082b7f95e6e6 Explicitly track inline comment reply threading
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 7 2015

1df321bf00a1 Fix left/right detection of inline comments in unified view
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 6 2015

f9cb366f0071 Remove duplicate inline scaffold in 2up renderer
Author
epriestley
Browse Repository
No Builds
No Audits

1352be827e12 Begin separating inline comment scaffolding from other renderers
Author
epriestley
Browse Repository
No Builds
No Audits

1088d34e58eb Rename inline comment views to "PHUIDiff" and give them a base class
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 9 2015

cdd8dcbf17bb Update InlineCommentSummary UI
Author
Chad Little
Browse Repository
No Builds
No Audits

Oct 7 2014

3cf9a5820fc9 Minor formatting changes
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Apr 28 2014

a46ead798007 Update inline-comment styles in Differential
Author
Chad Little
Browse Repository
No Builds
No Audits

Feb 21 2014

92ac8b5ad9a5 Make Differential inline comment rendering more consistent and somewhat more…
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 9 2013

fd8d9ff0d689 Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545.
Author
Jakub Vrana
Browse Repository
No Builds
No Audits

Feb 13 2013

ef7f16180ce5 Restore merge of phutil_tag.
Author
epriestley
Browse Repository
No Builds
No Audits

73cce6e1310b Revert "Promote phutil-tag again"
Author
epriestley
Browse Repository
No Builds
No Audits

4eb84149c2f1 Convert everything to safe HTML
Author
vrana
Browse Repository
No Builds
No Audits