Diffusion Phorge (HEAD -> master) History

phorge/src/applications/differential
HEAD -> mastere81eff68e581000b0d14caa…

Aug 11 2017

36197bf783e4 Provide revision status information via API all "differential.revision.search"
Author
epriestley
Browse Repository
No Builds
No Audits

ef8d4e2126af Fix an inverted condition for the "Reopen Revision" action
Author
epriestley
Browse Repository
No Builds
No Audits

153e4d8a383c Remove old reviewer double writes to legacy edge table in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

42020e135767 Completely remove "differential.find" Conduit API method
Author
epriestley
Browse Repository
No Builds
No Audits

13ddb15bbcfb Remove legacy `withStatus()` method from RevisionQuery
Author
epriestley
Browse Repository
No Builds
No Audits

50dfdb8d0355 Replace legacy Differential queries for "open" revisions with a modern mechanism
Author
epriestley
Browse Repository
No Builds
No Audits

53516093aed0 Replace Differential hard-coded status "<select />" with tokenizer
Author
epriestley
Browse Repository
No Builds
No Audits

8160baec2a6b Add a Differential revision status tokenizer datasource
Author
epriestley
Browse Repository
No Builds
No Audits

45b0fd8f9b53 Remove a debugging "echo" that crept in in dccd799b
Author
Alex Vandiver
Browse Repository
No Builds
No Audits

Aug 10 2017

7f90ef2d8261 Make the "Requested Changes to Prior Diff" reviewer icon red, not bluegrey
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 9 2017

46d1596bf797 Pull legacy revision query status filters out of the main Query class
Author
epriestley
Browse Repository
No Builds
No Audits

03ab7224bb4e Reduce STATUS_CLOSED (now internally "Published") revision status callsites
Author
epriestley
Browse Repository
No Builds
No Audits

70088f7eec8f Continue reducing callsites to ArcanistDifferentialRevisionStatus
Author
epriestley
Browse Repository
No Builds
No Audits

2e36653965a0 Reduce callsites to "ArcanistDifferentialRevisionStatus" in Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 6 2017

8ca29a607a2b Remove incorrect policy language on Diff reviewers
Author
Chad Little
Browse Repository
No Builds
No Audits

Jul 26 2017

e47f85cd98b8 In Differential, filter repository operations to just "Land" operations again
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 25 2017

1588d3e224fe In Differential, render status for any active Drydock repository operation, not…
Author
epriestley
Browse Repository
No Builds
No Audits

c217d7619c5f Make "A" hide or show all inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 9 2017

39e5da7ea700 Simplify Diffusion Browse Table
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 30 2017

596b83a7122a Move misplaced validation for ambiguous fields in "Test Plan" to the right place
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 27 2017

9d30d49cfc73 Convert "enum" and "string" config options to new modular option types
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 26 2017

d4632f4b78a0 Restore "Land Revision" action to UI
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 23 2017

219ae8b6c950 Remove old "Landing Strategy" code
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 15 2017

9b93697d52f4 Move "List Inline Comments" to the inline header dropdown menu
Author
epriestley
Browse Repository
No Builds
No Audits

b3b30dde6ac9 Add options for hidding inlines to the Differential header banner
Author
epriestley
Browse Repository
No Builds
No Audits

887bd2d66ef0 In the UI, rename "Hide Inline" to "Collapse Inline"
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 12 2017

283a95d2aae0 Build a page for viewing all inline comments
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 5 2017

d3c464a610bc Separate button CSS classes
Author
Chad Little
Browse Repository
No Builds
No Audits

48c6ca40c44f Add an "Unsaved" button to the Differential persistent header
Author
epriestley
Browse Repository
No Builds
No Audits

May 30 2017

d20221dc7d82 Remove Differential "objectives" UI
Author
epriestley
Browse Repository
No Builds
No Audits

May 26 2017

3fb4ca2429b7 Add needActiveDiffs to differential.createcomment method
Author
Chad Little
Browse Repository
No Builds
No Audits

04fd93e51e03 Drop DifferentialDraft storage
Author
Austin McKinley
Browse Repository
No Builds
No Audits

May 25 2017

19572f53fdfe Don't consider accepting on behalf of valid-but-accepted reviewers to be a…
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2017

00400ae6f965 Search and Replace calls to setShade
Author
Chad Little
Browse Repository
No Builds
No Audits

May 20 2017

af07600aaac7 Make Differential objective markers show a brighter "editing" state
Author
epriestley
Browse Repository
No Builds
No Audits

bdecff7d67ce Show "objectives" UI only if prototypes are enabled
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2017

fdf00f6df475 Clean up some minor UI behaviors in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

6c46f27d98c4 Add quest objectives to the minimap
Author
epriestley
Browse Repository
No Builds
No Audits

May 18 2017

fb9f3cc0b4ca Restore the "buoyant" header in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

f78ce156f114 Restore "h" to hide or show files, and modernize file visibility toggling
Author
epriestley
Browse Repository
No Builds
No Audits

May 17 2017

9eb285f4aabb Fix "left"/"right" changeset ID selection for synthetic deletions
Author
epriestley
Browse Repository
No Builds
No Audits

51df02821b86 Move the "select a line range" inline code to DiffInline
Author
epriestley
Browse Repository
No Builds
No Audits

422eb9db837d Correct the generation of "<th />" IDs on left-hand-side of image changesets
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2017

e4e91ebf6f15 In Differential, allow "r" to create comments and "R" to quote
Author
epriestley
Browse Repository
No Builds
No Audits

8052ab84bfd8 Remove "^" (Prev) and "V" (Next) actions on Differential inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

1b5a276a02d6 Add Differential keyboard shortcuts for "mark done" and "hide/show"
Author
epriestley
Browse Repository
No Builds
No Audits

2fb1edfeb198 Restore the Differential "edit" and "reply" keyboard shortcuts
Author
epriestley
Browse Repository
No Builds
No Audits

588a66c04d03 Move most Differetial keyboard shortcuts into DiffChangesetList
Author
epriestley
Browse Repository
No Builds
No Audits

4fd4ec3d275d Hide inlines one-by-one, instead of in a big group
Author
epriestley
Browse Repository
No Builds
No Audits

fe44e987fb16 Translate "Loading..." text in inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

64a54aac9d57 Merge "differential-dropdown-menus" behavior into DiffChangesetList
Author
epriestley
Browse Repository
No Builds
No Audits

May 14 2017

11c5638832c2 Fix some error log issues with uninitialized commit/revision lists
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 30 2017

b7c4f60e235d Only recognize "Fixes ..." in main revision content like the Summary or Test…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 20 2017

7a992b548898 When a package or project has been accepted or rejected, show who did it…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 11 2017

af1d494d66e9 Fix an issue where rejecting reviewers weren't powerful enough
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 10 2017

26d6096e0a5b When reviewing, always show "Accept" checkboxes for packages/projects, even if…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 6 2017

3a3626834e60 Replace Remarkup calls to `PhabricatorHash::digest()` with SHA256
Author
epriestley
Browse Repository
No Builds
No Audits

f1eeaaf59f7f Fix scope of "Accept" when you don't check all the "Force Accept" boxes
Author
epriestley
Browse Repository
No Builds
No Audits

cefbdbcffe9e Provide a "Reviewers" attachment to "differential.revision.search"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 4 2017

f70ff34d97e8 Fix a copy/paste typo with sticky accept
Author
epriestley
Browse Repository
No Builds
No Audits

873b39be8211 Remove PhabricatorFile::buildFromFileDataOrHash()
Author
epriestley
Browse Repository
No Builds
No Audits

45b386596e62 Make the Files "TTL" API more structured
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 3 2017

9ebb5f8cda56 Don't downgrade accepts on update (fix "sticky accept")
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 2 2017

163e1ec4426e Expose the commit/task/revision relationship edges to "edge.search"
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 28 2017

2fbc9a52da9b Allow users to "Force accept" package reviews if they own a more general package
Author
epriestley
Browse Repository
No Builds
No Audits

ddc02ce420a5 When voiding "Accept" reviews, also void "Reject" reviews
Author
epriestley
Browse Repository
No Builds
No Audits

415ad784844e Remove old code for "Request Review" action from Differential
Author
epriestley
Browse Repository
No Builds
No Audits

aea46e55dac0 Fix an issue where "Request Review" of a fully-accepted revision would…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 24 2017

24b6c7d7186a Allow users to resign if they have authority over any reviewer
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 23 2017

ffab52f17e19 Restrict Differential buckets to just ApplicationSearch views
Author
Chad Little
Browse Repository
No Builds
No Audits

Mar 22 2017

aa91dc992e24 Record which user accepted on behalf of packages/owners reviewers
Author
epriestley
Browse Repository
No Builds
No Audits

fab37aa4e35a When accepting revisions, allow users to accept on behalf of a subset of…
Author
epriestley
Browse Repository
No Builds
No Audits

e1ee8ba428e4 Fix a bad getStatus() call which is fataling during Herald rule evaluation
Author
epriestley
Browse Repository
No Builds
No Audits

3e7b63aa736a Add a <reviewer, revision> key to the reviewers table
Author
epriestley
Browse Repository
No Builds
No Audits

891355297074 Store "resigned" as an explicit reviewer state
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 20 2017

0ceab7d36f91 Rename "getReviewerStatus()" to "getReviewers()"
Author
epriestley
Browse Repository
No Builds
No Audits

a15df4f8d580 Rename "needReviewerStatus()" into "needReviewers()"
Author
epriestley
Browse Repository
No Builds
No Audits

d179d0150c4c Remove obsolete "relationships" code from Differential
Author
epriestley
Browse Repository
No Builds
No Audits

dccd799b1b44 Move many "reviewers" readers to new storage
Author
epriestley
Browse Repository
No Builds
No Audits

794b456530bc Store "last comment" and "last action" diffs on reviewers
Author
epriestley
Browse Repository
No Builds
No Audits

77b3efafbd4e Use ModularTransactions for accept/reject/resign in "differential.createcomment"
Author
epriestley
Browse Repository
No Builds
No Audits

a9cbbf3e5e15 Apply Owners reviewers using ModularTransactions
Author
epriestley
Browse Repository
No Builds
No Audits

216052baf982 Apply reviewer changes from Herald via ModularTransactions
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 17 2017

688c120f9f33 Provide PhabricatorEnv::isSelfURI to test if a URI points at the current install
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 16 2017

7626ec0ce10e Correct an issue where "View Raw File" in Differential generated a file with…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 14 2017

251ee9b660b8 Add dedicated "reviewers" storage to Differential and do double writes
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 2 2017

0a0ac1302f02 Prevent users from taking "edit"-like actions via comment forms if they don't…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 27 2017

6c21646b5f33 Put revisions waiting on other reviewers in their own bucket
Author
epriestley
Browse Repository
No Builds
No Audits

c5fa7421c222 Allow commits to be queried by repository using the `tagged(...)` typehaead…
Author
epriestley
Browse Repository
No Builds
No Audits

99bcf5f112dc Make `bin/lipsum generate` hanldle generator keys and arguments more clearly
Author
epriestley
Browse Repository
No Builds
No Audits

1b2c047ce0df Correct spelling of "phabrictor" in Lipsum and elsewhere
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 23 2017

84aff44bcd64 Add a "Red/Green Colorblind" accessibility mode, make all web UIs and email…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 17 2017

a778151f28c1 Fix errors found by PHPStan
Author
Jakub Vrana
Browse Repository
No Builds
No Audits

Feb 3 2017

fd0591e16880 Restore "Auditor" as an alias for the commit message field "Auditors"
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 31 2017

9b92e56dfc03 Don't link "Dxxx" on Differential revision pages
Author
epriestley
Browse Repository
No Builds
No Audits

bd9e54b62179 Navigage Buildkite builds with more nuance
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 30 2017

bc41c3f5a5b9 Use DifferentialCommitMessageParser and Modular Transactions to implement…
Author
epriestley
Browse Repository
No Builds
No Audits

e16080ce7e6c Fix typo in DifferentialRevisionCommandeerTransaction
Author
Sébastien Santoro
Browse Repository
No Builds
No Audits

Jan 25 2017

df939f1337fd Fix two issues with embedding other fields inside "Summary" or "Test Plan" in…
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 21 2017

20d1bb8fdf3d Remove counts from home navigation
Author
Chad Little
Browse Repository
No Builds
No Audits