HomePhorge

Fix "left"/"right" changeset ID selection for synthetic deletions

Description

Fix "left"/"right" changeset ID selection for synthetic deletions

Summary:
Fixes T8323. See that task for a description.

We were using nonempty(), but that rule doesn't cover synthetic deletions (file present in an earlier diff, but no longer present in the later diff).

Test Plan: Followed the steps in T8323, got a clean comment.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8323

Differential Revision: https://secure.phabricator.com/D17929

Details

Provenance
epriestleyAuthored on May 17 2017, 8:25 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP343f7cac72bb: Improve mobile/device behaviors for inline comments
Branches
Unknown
Tags
Unknown

Event Timeline