Diffusion Phorge (HEAD -> master) History

phorge/src/applications/differential
HEAD -> mastere81eff68e581000b0d14caa…

Feb 19 2019

cf048f4402fe Tweak some display behaviors for indent indicators
Author
epriestley
Browse Repository
No Builds
No Audits

fe7047d12d69 Display some invisible/nonprintable characters in diffs by default
Author
epriestley
Browse Repository
No Builds
No Audits

efccd75ae371 Correct various minor diff copy behaviors
Author
epriestley
Browse Repository
No Builds
No Audits

37f12a05ea62 Behold! Copy text from either side of a diff!
Author
epriestley
Browse Repository
No Builds
No Audits

d4b96bcf6b01 Remove hidden zero-width spaces affecting copy behavior
Author
epriestley
Browse Repository
No Builds
No Audits

98fe8fae4a90 Use `<td class="n" data-n="3">` instead of `<th>3</th>` for line numbers
Author
epriestley
Browse Repository
No Builds
No Audits

3f8eccdaec8f Put some whitespace behaviors back, but only for "diff alignment", not display
Author
epriestley
Browse Repository
No Builds
No Audits

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Browse Repository
No Builds
No Audits

661c758ff9d1 Render indent depth changes more clearly
Author
epriestley
Browse Repository
No Builds
No Audits

92abe3c8fb84 Extract scope line selection logic from the diff rendering engine so it can…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 15 2019

c5e16f9bd996 Give HarbormasterBuildUnitMessage a real Query class
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 14 2019

5892c7898603 Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 13 2019

a7bf279fd517 Don't try to publish build results to bare diffs
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 12 2019

1fd69f788cee Replace "getQueryParams()" callsites in Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 5 2019

b8fe991ba28e Improve description text in the "Create Diff" form
Author
Leopold Schabel
Browse Repository
No Builds
No Audits

Jan 31 2019

bc61d09f5553 Allow parent and child revisions to be modified via Conduit
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 30 2019

6bcfc212ebd4 Allow diff change detection to complete for Mercurial changes which remove a…
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 17 2019

c125ab7a42bf Remove "metamta.*.subject-prefix" options
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 16 2019

e3aa043a0272 Allow multiple mail receivers to react to an individual email
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 4 2019

73e3057c52f4 Rename "MetaMTA" mail attachments and add more mail message objects
Author
epriestley
Browse Repository
No Builds
No Audits

dda3ff89e06d Consolidate some application email receiver code in preparation for API changes
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 20 2018

11cf8f05b176 Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Author
epriestley
Browse Repository
No Builds
No Audits

937e88c399ab Remove obsolete, no-op implementations of "willRenderTimeline()"
Author
epriestley
Browse Repository
No Builds
No Audits

6c43d1d52cbd Remove "willRenderTimeline()" from ApplicationTransactionInterface
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 10 2018

46feccdfcf19 Share more inline "Done" code between Differential and Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 9 2018

1029081b2805 Correct two straggling "%Q" + "implode(...)" callsites in Revision updates
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 28 2018

c457d23a1d30 Tailor the "no reviewers on this revision" warnings to handle the case where…
Author
epriestley
Browse Repository
No Builds
No Audits

2f11001f6e3c Allow "Change Subtype" to be selected from the comment action stack
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 26 2018

9473f60a362f Allow "Abandoned" revisions to be commandeered
Author
epriestley
Browse Repository
No Builds
No Audits

bcc90d8c6b8c Fix an off-by-one error affecting mail rendering of inlines on the final line…
Author
epriestley
Browse Repository
No Builds
No Audits

97e7ef0f015c When the last rejecting reviewer resigns from a revision, return it to "Needs…
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 16 2018

b2e91d220539 Move the "container updated" message for Buildables that build Diffs outside of…
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 15 2018

44c32839a68c When you "Request Review" of a draft revision, change the button text from…
Author
epriestley
Browse Repository
No Builds
No Audits

2f10d4adebf9 Continue making application fixes to Phabricator for changes to %Q semantics
Author
epriestley
Browse Repository
No Builds
No Audits

98690ee326ce Update many Phabricator queries for new %Q query semantics
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 20 2018

e2cf1e42887a Skip copied code detection for changes that are too large for it to be useful
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 11 2018

0a51bc4f05bf Add a space after "View Inline" in mail to prevent double-click on the filename…
Author
epriestley
Browse Repository
No Builds
No Audits

4f54d483d5bf Support export of revisions to Excel/CSV/JSON/etc
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 5 2018

99034efa8b8d Make Pholio mail render without a ton of over-escaped HTML
Author
epriestley
Browse Repository
No Builds
No Audits

c6c1893dc0be Allow revisions to be filtered by created date
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 1 2018

39b85c0be039 Use the changeset parse cache when rendering inline comments in mail
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 7 2018

16a6fc8341ea Allow reviewers to mark their own inlines as "Done" before they submit them
Author
epriestley
Browse Repository
No Builds
No Audits

046c1b5b828d Expose "isDraft" and "holdAsDraft" revision properties over Conduit
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 6 2018

e8e5dc0f5690 Make a language improvement ("inlines" -> "inline comments")
Author
epriestley
Browse Repository
No Builds
No Audits

041392988ece When a transaction adds more than 100 inline comments, include only the first…
Author
epriestley
Browse Repository
No Builds
No Audits

650e74933abb Update some inline comment logic to use more modern "Viewer"-oriented…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 29 2018

75a04551524f Add "Revision test plan" as a Herald field; remove test plan from the "Revision…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 28 2018

614f9ba1fba6 Allow unit test results to specify that their details are formatted with…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 27 2018

632cafec881b Pass commit authorship information to Buildkite
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 24 2018

b584834b1934 In Differential: when the file tree is enabled, default to the "History" tab…
Author
epriestley
Browse Repository
No Builds
No Audits

5e4d9dfa9219 Condition "Changes Since Last Action" Differential link on "first broadcast"…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 17 2018

75a5dd8d8cc0 Add more accessibility labels for screen readers
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 13 2018

e5906f4e127e In Differential standalone views, disable some keyboard shortcuts which don't…
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 27 2018

9e451879d998 Add a "Changes Since Last Action" view to Differential revisions
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 23 2018

6b6e1f0ba890 Fix Lipsum generators for Differential Revisions and Pastes
Author
Kenneth Endfinger
Browse Repository
No Builds
No Audits

Jul 20 2018

67283c7a4526 Add test plan to differential.revision.search
Author
Austin McKinley
Browse Repository
No Builds
No Audits

Jul 13 2018

185c28f307e4 Update parent/child revision timeline messages to use modern language ("parent…
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 28 2018

a94528ee4aa1 Expose Differential actions for "transaction.search" in a basic way
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 12 2018

62a402491ae4 Allow encrypted mail to be more specific about which object is affected
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 8 2018

f37542717774 Use more consistent diff coloration in unified diffs
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2018

8f9b9484471a When showing a diff-of-diffs, hide files which didn't get any more changes and…
Author
epriestley
Browse Repository
No Builds
No Audits

79fdf5c12707 Separate changeset analysis code from DifferentialDiff and provide a standalone…
Author
epriestley
Browse Repository
No Builds
No Audits

May 14 2018

26d0862f4f6f Apply the new patch byte size limit to mail patch generation in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

May 7 2018

a4a22dd2f889 Mention the "inline comments" rule in the callout for "Large" diffs
Author
epriestley
Browse Repository
No Builds
No Audits

May 5 2018

5e2af4b9b5cd Prepare to support an "Ignore generated files" flag in Owners
Author
epriestley
Browse Repository
No Builds
No Audits

af295341c863 Classify changesets as "generated" at creation time, in addition to display time
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 30 2018

ee32c186dd82 Stop computing ownership for changed paths for Very Large revisions
Author
epriestley
Browse Repository
No Builds
No Audits

24305cadb902 Hide the "large" diff warning on "very large" diffs
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 27 2018

9f8e0ad473a6 Remove unusual unicode marks in Differential action dropdown
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 23 2018

16af0d35e510 In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 20 2018

9bf4df2c1ddf Allow demoted builds to automatically promote if builds pass after a restart
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 19 2018

843bfb4fd8ac Add a "commits" attachment to "differential.diff.search" for retrieving local…
Author
epriestley
Browse Repository
No Builds
No Audits

19403fdb8e29 Improve color use in "[+++- ]" element for colorblind users
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 16 2018

b5f23b023e3c Add an "--auto" flag to "bin/differential migrate-hunk"
Author
epriestley
Browse Repository
No Builds
No Audits

e3de7d09c0d8 Add an "--all" flag to "bin/differential migrate-hunk"
Author
epriestley
Browse Repository
No Builds
No Audits

6d1e00707680 Try a more conventional spelling of "Convereted"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 12 2018

4068aaef61a0 Toggle revision "shouldBroadcast" correctly when "--draft" is used with…
Author
epriestley
Browse Repository
No Builds
No Audits

c52e10d1ecf0 Respect external unmentionable PHIDs in Differential revision editor
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 8 2018

9bb338c0384e Revert the alternate menu names for applications
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 5 2018

f01c2e36948b Remove "Large Changes" documentation and make some minor behavioral improvements
Author
epriestley
Browse Repository
No Builds
No Audits

1b363a831e7c When a revision changes more than 1,000 files, don't show the changes on the…
Author
epriestley
Browse Repository
No Builds
No Audits

8c8e7f07b575 Add a standalone view for browsing changesets of very large revisions
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 3 2018

e70c9f72a48e Show revision sizes using a perplexing, inexplicable symbol code
Author
epriestley
Browse Repository
No Builds
No Audits

e40aec0210dc When a revision has more than 7 reviewers, render only the first 7 in the list…
Author
epriestley
Browse Repository
No Builds
No Audits

6f520e053462 Clean up an old transaction state flag
Author
epriestley
Browse Repository
No Builds
No Audits

804f9817c3e2 When a draft's builds fail and it demotes to "Changes Planned + Draft", notify…
Author
epriestley
Browse Repository
No Builds
No Audits

f4f33113124f When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not…
Author
epriestley
Browse Repository
No Builds
No Audits

adf8fdef0e89 When remote builds fail, demote revisions to "Changes Planned + But, Still A…
Author
epriestley
Browse Repository
No Builds
No Audits

d9bd36039fd1 When a non-broadcasting revision is updated, put it in "Draft", not "Needs…
Author
epriestley
Browse Repository
No Builds
No Audits

615d27c8e97f Show an additional "Draft" tag on non-broadcasting revisions in a non-draft…
Author
epriestley
Browse Repository
No Builds
No Audits

38e788c99a78 Partially decouple revision broadcasting from revision draft state
Author
epriestley
Browse Repository
No Builds
No Audits

3b5a7d1c88c4 Rename the Differential "hasBroadcast" flag to "shouldBroadcast"
Author
epriestley
Browse Repository
No Builds
No Audits

f350b9e4646b Explicitly condition Differential draft promotion on only "impactful" builds
Author
epriestley
Browse Repository
No Builds
No Audits

51461f18c15b When publishing buildables in Differential, ignore autobuilds (local lint and…
Author
epriestley
Browse Repository
No Builds
No Audits

95c9d403f4a3 Make objects implementing BuildableInterface produce a BuildableEngine
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 29 2018

79154455437b Fix two issues with Differential updates and Owners
Author
epriestley
Browse Repository
No Builds
No Audits

93cb6e3bdeb0 Make updating a revision with the same active diff a no-op
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 21 2018

73b68bc2a619 Fix a possible `count(null)` in DifferentialRevisionActionTransaction
Author
Tino Breddin
Browse Repository
No Builds
No Audits

Mar 14 2018

af8269d2fb06 Allow draft revisions to be commandeered
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 12 2018

1e93b49b1bf2 Allow custom actions in Differential to explicitly override "accept" stickiness
Author
epriestley
Browse Repository
No Builds
No Audits