HomePhorge

Fix an issue where rejecting reviewers weren't powerful enough

Description

Fix an issue where rejecting reviewers weren't powerful enough

Summary:
Previously, "reject" and "reject older" were separate statuses. Now, they're both shades of "reject".

Set the "older reject" flag properly when we find a non-current reject.

Test Plan:

  • User A accepts a revision.
  • User B rejects it.
  • Author updates it.
  • Before patch: incorrectly transitions to "accepted" ("older" reject is ignored).
  • After patch: correctly transitions to "needs review".

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D17653

Details

Provenance
epriestleyAuthored on Apr 11 2017, 9:51 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP28941b31059b: Update PhortuneMerchant to Modular Transactions
Branches
Unknown
Tags
Unknown

Event Timeline