Diffusion Phorge (HEAD -> master) History

phorge/src/applications/differential
HEAD -> mastere81eff68e581000b0d14caa…

May 4 2020

9307f57747b2 When rendering changesets, discard empty draft inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

f5ef341c9e35 Don't publish "empty" inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Browse Repository
No Builds
No Audits

468aabd4ef30 When draft inline comments are submitted, disengage the editor
Author
epriestley
Browse Repository
No Builds
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

5ff0ae7d48a7 Add generic "attributes" storage to inline comment tables
Author
epriestley
Browse Repository
No Builds
No Audits

17426a60f00a Fix an issue where text intradiff bodies may not render
Author
epriestley
Browse Repository
No Builds
No Audits

May 1 2020

b2cfcda114a4 Provide detailed information about reviewer changes in "transaction.search"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 30 2020

304467feb2ae Stabilize fatals when a build has a build plan the viewer can't see because of…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Browse Repository
No Builds
No Audits

befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 27 2020

aa20faeaa5d1 Fix an invalid index access for synthetic lint inline comments from Harbormaster
Author
epriestley
Browse Repository
No Builds
No Audits

c12db282519d For changesets that affect binaries, use the new binary file content hash as an…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 26 2020

b0c295e54509 Fix some PHP 7.4 array index access issues
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 25 2020

7355bb7f2956 Skip "null" lines when constructing raw documents for DocumentEngine rendering
Author
epriestley
Browse Repository
No Builds
No Audits

40d2346f2965 Add a missing "null" check when rebuilding old/new diff content
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 23 2020

d05d8f655896 Add a very forgiving GC for Differential viewstate information
Author
epriestley
Browse Repository
No Builds
No Audits

4793bfcb7c49 Don't show the "file tree" view on tablets/phones
Author
epriestley
Browse Repository
No Builds
No Audits

d2572f8b335a Refine more Differential review state behaviors
Author
epriestley
Browse Repository
No Builds
No Audits

0ede616f314b Update the "View Options" menu for recent filetree changes
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 22 2020

befbea2f00e6 Don't pass "No newline at end of file." annotations to DocumentEngines as…
Author
epriestley
Browse Repository
No Builds
No Audits

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

a72a66caa833 Mark "low importance" and "owned" changes in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

ff88eb588eb4 Show change information in file icons in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

12eddb18fb78 Entirely replace the old filetree UI with the "flank" UI
Author
epriestley
Browse Repository
No Builds
No Audits

ba8071bbef50 Roughly style the new "flank" paths UI
Author
epriestley
Browse Repository
No Builds
No Audits

8cd1f9a30976 Generate file trees from changesets in the new flank UI
Author
epriestley
Browse Repository
No Builds
No Audits

646280972b88 Glue the new FormationView on top of the older Filetree view in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 19 2020

3984c14260d3 Tokenize external editor links so they can be safely materialized on the client
Author
epriestley
Browse Repository
No Builds
No Audits

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Browse Repository
No Builds
No Audits

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 17 2020

3adf082002aa When inlines would disable a file shield in a diff, still apply the shield if…
Author
epriestley
Browse Repository
No Builds
No Audits

3d966d8a41f1 Add an "Open in External Editor" keystroke to Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 16 2020

894d9b658706 Remove Ferret function aliases and overrides
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 13 2020

471e89a8b76d Add "uri" to "paste.search" API output
Author
epriestley
Browse Repository
No Builds
No Audits

19e0abcb27b4 Fix an issue where raw diffs that are not attached to revisions could skip…
Author
epriestley
Browse Repository
No Builds
No Audits

5597f4e6f229 Add "uri" to the fields returned by "differential.revision.search"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 5 2020

f1d1ec3d77f1 Add an "isDone" flag to "transaction.search" for Differential inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 14 2020

64cc4fe91515 Add a test to verify that all routing maps are plausibly valid, and remove some…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 12 2020

dc35ce79e484 Unprototype "Draft" mode in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

f9b3e3360b0c Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 30 2020

ccf28a81121e Fix an issue where the last line of block-based diffs could be incorrectly…
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 22 2020

b38449ce8f4b Implement an "Author's packages" Herald field for Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 8 2019

72f82abe0723 Improve recovery from panel action rendering exceptions, and mark "Changeset"…
Author
epriestley
Browse Repository
No Builds
No Audits

d4491ddc225e Fix an issue with 1up diff block rendering for added or removed blocks
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 31 2019

b0d9f89c9535 Remove "State Icons" from handles
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 26 2019

292f8fc612bd Fix an issue where added or removed source files could incorrectly select a…
Author
epriestley
Browse Repository
No Builds
No Audits

8ff0e3ab351f Support rich diff rendering with DocumentEngine for added/removed files
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 17 2019

5dafabd5b4d0 Fix deprecated argument order for "implode()"
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 1 2019

9f7aaa8ee4cb Fix an issue where any diff which could possibly be rendered as Jupyter decided…
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 30 2019

76d9912932bc Force unified abstract block diffs into roughly usable shape
Author
epriestley
Browse Repository
No Builds
No Audits

d9515e82a3ec Perform basic block interdiffs when diffing abstract blocks, and interdiff…
Author
epriestley
Browse Repository
No Builds
No Audits

5afdc620db59 Make basic Juypter notebook rendering improvements and roughly support folding…
Author
epriestley
Browse Repository
No Builds
No Audits

a7f3316aa3df Improve sequencing of various content/header checks in abstract block diffs
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 25 2019

2c06815edb0f When rendering Jupyter notebook diffs, split code inputs into individual blocks
Author
epriestley
Browse Repository
No Builds
No Audits

281598d65cfc Use a hash-and-diff strategy to produce a diff layout for block-based documents
Author
epriestley
Browse Repository
No Builds
No Audits

932d829af339 Improve behavior of inline comment highlight reticle for block diffs
Author
epriestley
Browse Repository
No Builds
No Audits

a09b298d85d7 Correct DOM node metadata to let inline comments work against block-based diffs
Author
epriestley
Browse Repository
No Builds
No Audits

1c4450d39f9b Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…
Author
epriestley
Browse Repository
No Builds
No Audits

7ae711ed3e0b Add a "View as..." option to diff dropdowns for selecting between document…
Author
epriestley
Browse Repository
No Builds
No Audits

bb71ef6ad6cd Render image diffs as abstract blocks diffs via DocumentEngine
Author
epriestley
Browse Repository
No Builds
No Audits

a73f592d7d08 Allow DocumentEngine to elect into diff construction
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 22 2019

353155a2034e Add "modifiedStart" and "modifiedEnd" constraints to "differential.revision.
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 21 2019

5741514aeb5b When a client submits an overlong "sourcePath", truncate it and continue
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 18 2019

753828649956 Fix missing link targets for "View Object" header buttons in HTML email
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 17 2019

14b076578f8e In "Download Raw Diff", engage the chunk engine to handle 8MB+ changes
Author
epriestley
Browse Repository
No Builds
No Audits

2bc045bab8d7 Fix another stray "msort()/msortv()" issue
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 4 2019

760406762a6f When a revision is closed, always promote it out of draft
Author
epriestley
Browse Repository
No Builds
No Audits

May 30 2019

9a32a563f047 Add a "View Task" button to HTML mail from Maniphest
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2019

b95bf722d55e Drop the "update revision with commit diff" transaction if the revision is…
Author
epriestley
Browse Repository
No Builds
No Audits

1eff4fdca332 Prevent "Differential Revision: ..." from counting as a mention in commit…
Author
epriestley
Browse Repository
No Builds
No Audits

fa4dcaa3aaff Stabilize sorting of feed stories with similar strength
Author
epriestley
Browse Repository
No Builds
No Audits

May 21 2019

7c1f6519e0b2 Support "none()" in Differential to find revisions with no (un-resigned)…
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2019

6bff2cee22fc Improve the performance of tab replacement in common cases
Author
epriestley
Browse Repository
No Builds
No Audits

4a3481a49384 Enrich "draft", "summary", and "testPlan" transactions from Differential in…
Author
epriestley
Browse Repository
No Builds
No Audits

May 7 2019

7a8d489ebdbd Fix a HunkParser typo, "identcal" -> "identical"
Author
epriestley
Browse Repository
No Builds
No Audits

May 1 2019

a15b0063df3d Add "Revision has passing builds" Herald rules for commit content (pushes) and…
Author
epriestley
Browse Repository
No Builds
No Audits

a78f141b3fa8 Unify code for parsing "Reverts X" magic, and when something "reverts <hash>"…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 30 2019

6eae75d8f2ff When building a synthetic diff in Differential, adjust diff properties correctly
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 24 2019

a2d3d8edeb93 Move "update related object after commit" to a separate worker in the task queue
Author
epriestley
Browse Repository
No Builds
No Audits

42c02557e4e3 Remove all remaining readers and writers for TABLE_COMMIT
Author
epriestley
Browse Repository
No Builds
No Audits

ec0085fd0c7a Align "RevisionQuery->needCommitPHIDs()" to use Edges, not the legacy table
Author
epriestley
Browse Repository
No Builds
No Audits

7e8dc0742bdc Remove all callers to "DifferentialRevision->loadIDsByCommitPHIDs()"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 23 2019

7b8ac020b521 Change "Revision Close" story to use commit identities only with no fallback to…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 17 2019

5b6d6c4fb313 Use repository identities, not denormalized strings, to identify authors for…
Author
epriestley
Browse Repository
No Builds
No Audits

4b8a67ccde91 Index and show Owners packages affected by Herald rules
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 11 2019

d02256df3ca5 Remove very old "vsDiff" data from commit update / diff extraction pipeline
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 10 2019

9e65e6c50342 Support "JIRA Issue URIs" as a Herald field for revisions
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 2 2019

c9d3fb2ac5b6 Fix the incorrect link target for "Create Revision" as a Menu Item
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 1 2019

cddbe306f927 Correct a case where a single-hunk diff may incorrectly be identified as multi…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 19 2019

d4847c3eeb78 Convert simple query subclasses to use internal cursors
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 7 2019

a3ebaac0f026 Tweak the visual style of the ">>" / "<<" depth change indicators slightly
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 6 2019

7e4681234467 Add a warning to revision timelines when changes land with ongoing or failed…
Author
epriestley
Browse Repository
No Builds
No Audits

718cdc24471a Implement Build Plan "Hold Drafts" behavior
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 5 2019

cc8dda629905 Recognize the official "Go" magic regexp for generated code as generated
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 28 2019

814e6d2de927 Add more type checking to transactions queued by Herald
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 25 2019

dc9aaa0fc2bf Fix a stray "%Q" warning when hiding/showing inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 20 2019

1b8325642112 Don't enable the "ScopeEngine" or try to identify scope context for diffs…
Author
epriestley
Browse Repository
No Builds
No Audits

f1a035d5c2c6 In Differential, give the "moved/copied from" gutter a more clear visual look
Author
epriestley
Browse Repository
No Builds
No Audits

a33409991c27 Remove an old Differential selection behavior
Author
epriestley
Browse Repository
No Builds
No Audits