Diffusion Phorge (master) History

phorge/src/applications/differential
master25aebab655fdb50118b8dcc…

Feb 5 2024

25aebab655fd Make misc get*ApplicationClass[Name]() calls return ::class constant instead of…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jan 28 2024

064424c1b755 Add getQueryApplicationClass() to *TransactionQuery.php classes
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Nov 21 2023

1b49165ddd16 Show more in Application Detail and List view
Author
Matthew Bowker
Browse Repository
No Builds
No Audits

Aug 12 2023

e8ea7a4a3697 Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector()
Author
Steve Campbell
Browse Repository
No Builds
No Audits

Aug 11 2023

eb0bb1736891 Replace dedicated Commit Field with an existing one
Author
Aviv Eyal
Browse Repository
No Builds
No Audits

8310591523f5 Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors
Author
sten
Browse Repository
No Builds
No Audits

4b3c384856da Fix DifferentialCommitMessageField renderFieldValue PHP 8.1 strlen(null) error
Author
Steve Campbell
Browse Repository
No Builds
No Audits

Jul 29 2023

4cedb928aa20 Fix arc patch PHP 8.1 strlen(null) error
Author
sten
Browse Repository
No Builds
No Audits

Jul 25 2023

1e3c9bdfee76 Update Diff: fix dead-end when not yours
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

Jul 22 2023

0f07c07b3bc3 Attach Diff to Revision: fix Repository asked twice
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

Jul 17 2023

8cbbc9f96107 Fix strlen(null) in DifferentialChangesetViewController loadCoverage()
Author
Steve Campbell
Browse Repository
No Builds
No Audits

Jul 6 2023

b3ac5ceb387f Fix DifferentialGetCommitMessageConduitAPIMethod execute strlen(null)
Author
Steve Campbell
Browse Repository
No Builds
No Audits

Jul 5 2023

9d512595c0e2 Fix PHP 8.1 DifferentialBranchField getBranchDescription strlen(null) error
Author
Steve Campbell
Browse Repository
No Builds
No Audits

Jun 8 2023

25c4f6224d63 Fix some PHP 8.1 "strlen(null)" exceptions on Differential Revision page
Author
Andre Klapper
Browse Repository
No Builds
No Audits

44a8a1c408ed Fix PHP 8.1 "preg_match(null)" exception on "Create Revision" page in…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 30 2023

f2329f816504 Correct two spelling mistakes in Differential
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Mar 25 2023

42a8b73adbaa Feed Differential retitled: do not repeat the title twice
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

May 24 2022

8e703c8c351d Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 25 2022

55770a2ca8d7 Remove product literal strings in "pht()", part 17
Author
epriestley
Browse Repository
No Builds
No Audits

ad880491e8d6 Remove product literal strings in "pht()", part 5
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 27 2021

cc8cbed02941 Make "DifferentialDiff->properties" a proper "attachable" property
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 25 2021

a641ec82a323 Add an "Authority" control to Packages to support "Watcher" packages
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 29 2021

428fff2e58f3 Fix an issue when undoing mutiple inline comment deletions
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 17 2021

db9191f9a8d5 Correct minor "jump to symbol" behavior in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

d6ed9392d4e0 Replace Differential "lint stars" with icons
Author
epriestley
Browse Repository
No Builds
No Audits

527dd3ce50b2 Replace Differential "unit stars" with icons
Author
epriestley
Browse Repository
No Builds
No Audits

1d1003af7854 When using "Update Diff" from the web UI, prefill "Repository" properly
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 15 2021

30d58de1bc22 Expose "affectedPaths" to "differential.revision.search" Conduit API method
Author
epriestley
Browse Repository
No Builds
No Audits

6d33ba7dc401 Move Diffusion to "withPaths()" for "Recent Open Revisions", and remove…
Author
epriestley
Browse Repository
No Builds
No Audits

925c9a71e7ea Support a "withPaths()" API in DifferentialRevisionQuery, and use it on the…
Author
epriestley
Browse Repository
No Builds
No Audits

26c68942bd00 Update "AffectedPath" table when a revision's repository changes
Author
epriestley
Browse Repository
No Builds
No Audits

01ea84029d88 Update table schema for "AffectedPath" table
Author
epriestley
Browse Repository
No Builds
No Audits

38ef910da8ca Move "Affected Path" index updates to a separate class
Author
epriestley
Browse Repository
No Builds
No Audits

e919b4c35a2a Add a debug view of the "Affected Path" index to Differential
Author
epriestley
Browse Repository
No Builds
No Audits

c317d16bdd56 Lift peculiar side effect of path indexing out of indexer
Author
epriestley
Browse Repository
No Builds
No Audits

bcd592cf7e15 Remove support for "paths" parameter in "differential.query"
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 4 2021

fceb9a3f9e1d Hide the "Author" field in Differential on the web create workflow
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 3 2021

f3caf7e9fcd6 Improve rendering behavior for "foist upon" with an empty tokenizer
Author
epriestley
Browse Repository
No Builds
No Audits

dec14136844d Provide a more general "Author" transaction for Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 23 2021

6bfa990254a2 When mapping phantom comments across changes, correct an off-by-one issue
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 15 2021

9feb7343e662 Provide a "differential.changeset.search" Conduit API method
Author
epriestley
Browse Repository
No Builds
No Audits

ec5476a01f5f Add a PHID to Changesets
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 13 2021

42c26821ef92 When a revision has only human reviewers but none can view it, show a warning…
Author
epriestley
Browse Repository
No Builds
No Audits

2f33dedc8b62 When a reviewer can't see a revision, show it clearly in the reviewer list
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 3 2021

9502312b60ae Remove "final" from "private" methods in Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 26 2021

acd767c7f33d Allow "differential.createinline" to accept JSON "false" for "isNewFile"
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 16 2020

2b8bbae5fb27 Set an explicit height when drawing the dependent revision graph
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 15 2020

2a83df578604 Fix an issue where a GROUP BY was missing when a query matched a revision using…
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 8 2020

6e1b5da1121c Fix additional "xprintf()"-class static parameter lint errors
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 5 2020

dbdfac1e072e Recover inline comments which are "adjusted" off the end of a diff
Author
epriestley
Browse Repository
No Builds
No Audits

98e0440d459b In 1-up source diffs, retain the "No newline at end of file" on "\" lines
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 24 2020

017ef1927c3e Revert use of "user-select: all" to modify tab selection behavior
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 22 2020

8f9ba4852861 Fix an issue with destruction of Revision and Diff objects with viewstates
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 17 2020

0ed5569e9f7b Likely, fix a warning when rendering modified coverage
Author
epriestley
Browse Repository
No Builds
No Audits

37ffb71c4d5e In source views, wrap display tabs in "user-select: all" to improve cursor…
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 9 2020

1d4d860cb5a0 Allow non-authors to "Request Review" of draft revisions
Author
epriestley
Browse Repository
No Builds
No Audits

b21b73b8dd35 Expand Revision transaction API to allow actions to vary more broadly based on…
Author
epriestley
Browse Repository
No Builds
No Audits

May 23 2020

a529efa5b855 Fix an issue where inline comments with only edit suggestions are considered…
Author
epriestley
Browse Repository
No Builds
No Audits

May 21 2020

66566f878d82 Make "Open in Editor" use the simple line number of the current selected block
Author
epriestley
Browse Repository
No Builds
No Audits

May 20 2020

d3d41324be9f Drop old "differential_commit" table
Author
epriestley
Browse Repository
No Builds
No Audits

6d0dbeb77f77 Use the changeset parse cache to cache suggestion changesets
Author
epriestley
Browse Repository
No Builds
No Audits

5d0ae283a9ab Put a readthrough cache in front of inline context construction
Author
epriestley
Browse Repository
No Builds
No Audits

d2d7e7f5ff1b Clean up Diffusion behaviors for inline edit suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Browse Repository
No Builds
No Audits

846562158aae Roughly support inline comment suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

4b2a447003be Allow "has draft inlines?" queries to overheat
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2020

43a8d8763df3 Update out-of-date API calls when rendering diffs inline in email
Author
epriestley
Browse Repository
No Builds
No Audits

6cf017d68003 Fix an unusual issue with intradiff highlighting of files with uncommon end-of…
Author
epriestley
Browse Repository
No Builds
No Audits

May 14 2020

3ee6b5393c77 Improve offset/range inline behavior for rich diffs and unified diffs
Author
epriestley
Browse Repository
No Builds
No Audits

May 13 2020

42378ea393fe Allow users to create inline comments by directly selecting text directly
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2020

df139f044b9b Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Author
epriestley
Browse Repository
No Builds
No Audits

e8109e4a9224 When an inline was left on a rendered DocumentEngine document, don't include an…
Author
epriestley
Browse Repository
No Builds
No Audits

acc1fa165519 Make "View as Document Type..." only show valid options
Author
epriestley
Browse Repository
No Builds
No Audits

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Browse Repository
No Builds
No Audits

May 8 2020

6dc20d1e2e71 Fix an issue where storage inlines are fed to InlineAdjustmentEngine
Author
epriestley
Browse Repository
No Builds
No Audits

24ba66f106f2 Persist "Show Changeset" and improve path text selection
Author
epriestley
Browse Repository
No Builds
No Audits

fa2d30ee3698 Lift inline comment draft behaviors to "InlineController"
Author
epriestley
Browse Repository
No Builds
No Audits

May 7 2020

94a95efa059a Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

79107574a762 Remove "DifferentialInlineCommentQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

983d77848b4c Move the "Inline List" view to "DiffInlineCommentQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

af5b94b23473 Lift most "InlineController" querying to the base class
Author
epriestley
Browse Repository
No Builds
No Audits

c1f1345cc053 Make InlineCommentQueries more robust/consistent
Author
epriestley
Browse Repository
No Builds
No Audits

1656a2ff081a Allow inline comment storage objects to generate their own runtime objects
Author
epriestley
Browse Repository
No Builds
No Audits

397648855f8b Make the "attach_inlines" parameter to "differential.createcomment" a no-op
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

a590db28b254 Fix an issue where non-ID changeset state keys were used as changeset IDs
Author
epriestley
Browse Repository
No Builds
No Audits

6430d6d638eb Fix an intradiff error when the newer changeset does not exist
Author
epriestley
Browse Repository
No Builds
No Audits

7fa47408a3c5 When a user submits "isEditing" inlines and chooses to publish them, publish…
Author
epriestley
Browse Repository
No Builds
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Browse Repository
No Builds
No Audits

27b7ba814a5a Don't consider empty inlines when considering whether a revision has draft…
Author
epriestley
Browse Repository
No Builds
No Audits

9307f57747b2 When rendering changesets, discard empty draft inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

f5ef341c9e35 Don't publish "empty" inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Browse Repository
No Builds
No Audits

468aabd4ef30 When draft inline comments are submitted, disengage the editor
Author
epriestley
Browse Repository
No Builds
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

5ff0ae7d48a7 Add generic "attributes" storage to inline comment tables
Author
epriestley
Browse Repository
No Builds
No Audits

17426a60f00a Fix an issue where text intradiff bodies may not render
Author
epriestley
Browse Repository
No Builds
No Audits

May 1 2020

b2cfcda114a4 Provide detailed information about reviewer changes in "transaction.search"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 30 2020

304467feb2ae Stabilize fatals when a build has a build plan the viewer can't see because of…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 28 2020

f21f1d8ab9e9 Update the diff table of contents to use hierarchical views and edit distance…
Author
epriestley
Browse Repository
No Builds
No Audits

befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Browse Repository
No Builds
No Audits