HomePhorge

Allow "differential.createinline" to accept JSON "false" for "isNewFile"

Description

Allow "differential.createinline" to accept JSON "false" for "isNewFile"

Summary:
See https://discourse.phabricator-community.org/t/error-creating-inline-comment-via-conduit-api/4535. See T12678.

This API method currently does not accept a JSON "false", but reasonably should.

Test Plan:

  • Called method with "isNewFile: false".
    • Before: type error.
    • After: inline comment.

Differential Revision: https://secure.phabricator.com/D21522

Details

Provenance
epriestleyAuthored on Jan 26 2021, 2:45 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPed86c42b26b0: Improve performance of repository discovery in repositories with >65K refs
Branches
Unknown
Tags
Unknown

Event Timeline