HomePhorge

Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector()

Description

Fix PHP 8.1 issue in DifferentialChangeset getOldStatePathVector()

Summary:
The DifferentialChangeset getOldStatePathVector() method assumes oldFile and filename are set.
This worked under PHP <= 8.0, but fails for PHP >= 8.1 with error messsage

strlen(): Passing null to parameter #1 ($string) of type string is deprecated

Fixes T15517

Test Plan:
Create a diff in which a new file is added.
This file will have oldFile NULL and filename a string.
View the diff https://my.phorge.site/D1234

Reviewers: O1 Blessed Committers, Matthew

Reviewed By: O1 Blessed Committers, Matthew

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15517

Differential Revision: https://we.phorge.it/D25323

Details

Provenance
Steve CampbellAuthored on Aug 12 2023, 12:37 AM
stenCommitted on Aug 12 2023, 12:39 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP98dfac53ba72: Fix PHP 8.1 "strlen(null)" exceptions blocking account registration with custom…
Branches
Loading...
Tags
Loading...

Event Timeline