Diffusion Phorge (master) History

phorge/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
masteraa2b70708e2fa962cc65527…

Sep 9 2024

aa2b70708e2f PHPDoc: Replace "@return this" with "@return $this"
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Aug 21 2024

b44b566b1334 Add missing variable names to PHPDoc @param of methods
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Aug 4 2024

93c9afd2f387 Do not add actor as subscriber when removing a comment
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 9 2024

b6f132f04f06 TransactionEditor: micro-optimize the "creation finder"
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

Feb 29 2024

6df26b98c104 Comments: avoid confusing warning about "core:file"
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

May 27 2023

4862eada5cd0 Correct spelling mistakes
Author
Edward Betts
Browse Repository
No Builds
No Audits

Apr 29 2023

ac99285c57a0 Fix numerous PHP 8.1 "strlen(null)" exceptions trying to create a project
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 25 2022

5aa159a83013 Pass "object" to modular transaction methods explicitly
Author
epriestley
Browse Repository
No Builds
No Audits

May 24 2022

5493f028dca6 Provide a simple "Attach File" explicit workflow for files referenced but not…
Author
epriestley
Browse Repository
No Builds
No Audits

May 23 2022

5033ef6f88b3 Give "FileAttachment" policy support and a query object
Author
epriestley
Browse Repository
No Builds
No Audits

2a0feb3de0e2 Only attach files that are both referenced in Remarkup and attached by explicit…
Author
epriestley
Browse Repository
No Builds
No Audits

8cd02e6727e3 Provide missing default attachment list for Files transactions
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2022

42876de60d28 Generate file attachment transactions for explicit Remarkup attachments on…
Author
epriestley
Browse Repository
No Builds
No Audits

c25a8fabfc1e Remove all "ObjectHasFile" edge reads and writes
Author
epriestley
Browse Repository
No Builds
No Audits

d017f3f21021 Double-write file attachment to old "edge" storage and new "attachment" storage
Author
epriestley
Browse Repository
No Builds
No Audits

6fea5e5ce7d5 Do not extract file PHIDs from remarkup blocks for attachment
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 19 2022

21b1a304b60a Improve some PHP 8.1 behavior in "bin/auth recover"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 1 2022

c25595417f8a Give Phame blogs mutable interact policies
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 3 2021

9502312b60ae Remove "final" from "private" methods in Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 9 2020

6e85b521fe86 Don't raise the "Subscribers Won't Be Notified" draft warning if you aren't…
Author
epriestley
Browse Repository
No Builds
No Audits

May 7 2020

94a95efa059a Replace "loadUnsubmittedInlineComments()" with a modern "DiffQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

f5ef341c9e35 Don't publish "empty" inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

67da18e37478 When users submit "editing" inlines, warn them that their inlines will be saved
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 30 2020

12c337098872 When issuing a "no-op" MFA token because no MFA is configured, don't give the…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 26 2019

a0a38797127f In Phortune, send order email to account external addresses
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 23 2019

cd449254256d Allow users with no CAN_EDIT permissions to silence projects if they want to
Author
Arturas Moskvinas
Browse Repository
No Builds
No Audits

Jun 18 2019

753828649956 Fix missing link targets for "View Object" header buttons in HTML email
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 17 2019

874282db7589 Correct "msort()" vs "msortv()" to more fully stabilize transaction sorts after…
Author
epriestley
Browse Repository
No Builds
No Audits

May 30 2019

81134d7e7d54 After reloading transactions for the recipient while building transaction mail…
Author
epriestley
Browse Repository
No Builds
No Audits

9a32a563f047 Add a "View Task" button to HTML mail from Maniphest
Author
epriestley
Browse Repository
No Builds
No Audits

May 23 2019

ce6fc5be9092 Fix a looping workflow when trying to submit a partially-effectless transaction…
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2019

31e623afcc92 Use the same transaction group ID for transactions applied indirectly by a sub…
Author
epriestley
Browse Repository
No Builds
No Audits

1eff4fdca332 Prevent "Differential Revision: ..." from counting as a mention in commit…
Author
epriestley
Browse Repository
No Builds
No Audits

fa4dcaa3aaff Stabilize sorting of feed stories with similar strength
Author
epriestley
Browse Repository
No Builds
No Audits

May 21 2019

b8f6248e0782 Fix an issue where handles could load with the incorrect viewer when building…
Author
epriestley
Browse Repository
No Builds
No Audits

May 17 2019

167f06d3eb70 Label transaction groups with a "group ID" so Herald can reconstruct them…
Author
epriestley
Browse Repository
No Builds
No Audits

May 14 2019

3e0391c574f2 Don't mark subscribes/mentions as "Lock Overridden"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 29 2019

0d9362355b1e In ApplicationTransactionEditor, determine new objects with "getID()" instead…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 24 2019

b3b1cc64bdd0 When applying transactions, acquire a read lock sooner
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 28 2019

15cc475cbd8c When a comment was signed with MFA, require MFA to edit it
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 18 2019

a6fd8f04792d When performing complex edits, pause sub-editors before they publish to…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 13 2019

04f9e72cbd10 Don't subscribe bots implicitly when they act on objects, or when they are…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 28 2019

814e6d2de927 Add more type checking to transactions queued by Herald
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 19 2019

e44b40ca4d83 Make "Subscribe/Unsubscribe" require only "CAN_VIEW", not "CAN_INTERACT"
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 9 2019

a20f10803412 When an edit overrides an object lock, note it in the transaction record
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 7 2019

9f5e6bee9037 Make the default behavior of getApplicationTransactionCommentObject() "return…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 1 2019

7c795ab75722 Let omnipotent actors skip MFA transactions
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 31 2019

b33333ab8e7a Fix method name typo in new modular transaction text/html mail methods
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 30 2019

138c07f32c79 Allow modular transactions to override transaction title and body text in mail
Author
epriestley
Browse Repository
No Builds
No Audits

93b512b63cca Update a factor query in TransactionEditor for providers
Author
epriestley
Browse Repository
No Builds
No Audits

f7e8fa0764fe Provide an Editor extension point for transaction validation
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 28 2019

d24e66724d3b Convert "Rename User" from session MFA to one-shot MFA
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 23 2019

587e9cea19ac Always require MFA to edit contact numbers
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 20 2019

afd2ace0dc9c Apply inverse edge edits after committing primary object edits
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 16 2019

0c0cbb1c09e4 Fix an issue where transactions in mail were always rendered as text
Author
epriestley
Browse Repository
No Builds
No Audits

966a93334c85 Don't require "CAN_EDIT" to watch/unwatch a project
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 28 2018

106e90dcf086 Remove the "willApplyTransactions()" hook from ApplicationTransactionEditor
Author
epriestley
Browse Repository
No Builds
No Audits

efb01bf34f60 Allow "MFA Required" objects to be edited without MFA if the edit is only…
Author
epriestley
Browse Repository
No Builds
No Audits

d3c325c4fc73 Allow objects to be put in an "MFA required for all interactions" mode, and…
Author
epriestley
Browse Repository
No Builds
No Audits

543f2b6bf156 Allow any transaction group to be signed with a one-shot "Sign With MFA" action
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 20 2018

11cf8f05b176 Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 10 2018

773b4eaa9ea0 Separate "feed" and "notifications" better, allow stories to appear in…
Author
epriestley
Browse Repository
No Builds
No Audits

ba833805656e Update the "Notification Test" workflow to use more modern mechanisms
Author
epriestley
Browse Repository
No Builds
No Audits

508df60a6217 When users mark their own inline comments as "Done", suppress the timeline/mail…
Author
epriestley
Browse Repository
No Builds
No Audits

46feccdfcf19 Share more inline "Done" code between Differential and Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 9 2018

f0eefdd0b58b Replace the informal "array" subtype map with a more formal "SubtypeMap" object
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 16 2018

b2e91d220539 Move the "container updated" message for Buildables that build Diffs outside of…
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 12 2018

f5e90a363e7a When a user takes actions while in a high security session, note it on the…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 24 2018

4d89afcc6149 Remove requireCapabilities() from ApplicationTransactionEditor and require…
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 27 2018

a5d3aea67c5b Carry the "silent" transaction flag through inverse edge edits
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 16 2018

f9b3673fbbe1 When mail (like "!history" mail) has multiple comments, label them separately
Author
epriestley
Browse Repository
No Builds
No Audits

25965260c431 Add a rough "!history" email command to get an entire object history via email
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 3 2018

ada0c9126cf0 Provide a modular buildable transaction in Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 28 2018

b586ee065a75 Stop evaluating Herald rules when writing "someone mentioned this somewhere…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 21 2018

6ed123e0801a Propagate "unexpandable" PHIDs to feed notification recipient expansion
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 12 2018

df8d4dff679b Raise a warning when mentioning a user in a comment on a draft revision
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 16 2018

bfdc9411f705 Provide context objects for remarkup mail rendering, fixing Phriction relative…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 12 2018

66f20595e4d2 Start buildables in "PREPARING", move them to "BUILDING" after builds queue
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 10 2018

653bc0fa019f Read lock all transaction edits
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 9 2018

64177cb16e77 Document how webhooks work
Author
epriestley
Browse Repository
No Builds
No Audits

98c701ffc55f Add a "Call webhooks" action to Herald
Author
epriestley
Browse Repository
No Builds
No Audits

41d28abfcc46 Trigger all "Firehose" webhooks on all transactional edits
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 8 2018

ab04d2179bf1 Add "Mute/Unmute" for subscribable objects
Author
epriestley
Browse Repository
No Builds
No Audits

bca9c08953bd Add an "Acting user" field to Herald
Author
epriestley
Browse Repository
No Builds
No Audits

1cd3a593784a When users resign from revisions, stop expanding projects/packages to include…
Author
epriestley
Browse Repository
No Builds
No Audits

f214abb63f9d When a change removes recipients from an object, send them one last email
Author
epriestley
Browse Repository
No Builds
No Audits

994d2e8e1563 Use "cluster.mailers" if it is configured
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 6 2018

56bf0690804f Try running Herald when performing inverse edge edits
Author
epriestley
Browse Repository
No Builds
No Audits

1bf64e5cbcf4 Add Differential and Herald mail stamps and some refinements
Author
epriestley
Browse Repository
No Builds
No Audits

3131e733a85c Add Editor-based mail stamps: actor, via, silent, encrypted, new, mention, self…
Author
epriestley
Browse Repository
No Builds
No Audits

c3f95bc410a3 Add basic support for mail "stamps" to improve client mail routing
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 2 2018

cbe4e68c0722 Add a Herald action to trigger "Must Encrypt" for mail
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 29 2018

e5639a8ed90f Write edge transactions in a more compact way
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 26 2018

fd66ab55791e Always use the same set of transactions to generate mail and mail tags
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 19 2018

8b12fa6d6ed0 Prepare TransactionEditor for silent transactions via bulk edit
Author
epriestley
Browse Repository
No Builds
No Audits

8a5def8e0ae1 Remove legacy transaction editor "getDisableEmail()" method
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 4 2018

129e3a120849 Fix a minor/harmless race with feed publishers in certain draft states
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 5 2017

6d3baa92f908 Execute Herald again after promoting revisions out of the "Draft" state
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
Dmitri Iouchtchenko
Browse Repository
No Builds
No Audits

Sep 21 2017

36df39761ea5 Create revisions into "Draft", publish them when builds finish
Author
epriestley
Browse Repository
No Builds
No Audits