HomePhorge

Fix numerous PHP 8.1 "strlen(null)" exceptions trying to create a project

Description

Fix numerous PHP 8.1 "strlen(null)" exceptions trying to create a project

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If your phutil_nonempty_string() throws an exception, just
report it to Phorge to evaluate and fix together that specific corner case.

Closes T15286

Test Plan: Applied these five changes and /project/view/1/ finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15286

Differential Revision: https://we.phorge.it/D25140

Details

Provenance
Andre KlapperAuthored on Apr 29 2023, 5:40 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPc37412df45da: Fix numerous PHP 8.1 "strlen(null)" exceptions trying access Configuration page
Branches
Unknown
Tags
Unknown

Event Timeline