Diffusion Phorge (master) History

phorge/src/applications/differential/parser/DifferentialChangesetParser.php
masteraa2b70708e2fa962cc65527…

Sep 9 2024

aa2b70708e2f PHPDoc: Replace "@return this" with "@return $this"
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Aug 21 2024

b44b566b1334 Add missing variable names to PHPDoc @param of methods
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Apr 25 2022

ad880491e8d6 Remove product literal strings in "pht()", part 5
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 5 2020

dbdfac1e072e Recover inline comments which are "adjusted" off the end of a diff
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 24 2020

017ef1927c3e Revert use of "user-select: all" to modify tab selection behavior
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 17 2020

0ed5569e9f7b Likely, fix a warning when rendering modified coverage
Author
epriestley
Browse Repository
No Builds
No Audits

37ffb71c4d5e In source views, wrap display tabs in "user-select: all" to improve cursor…
Author
epriestley
Browse Repository
No Builds
No Audits

May 20 2020

6d0dbeb77f77 Use the changeset parse cache to cache suggestion changesets
Author
epriestley
Browse Repository
No Builds
No Audits

10f241352dce Render inline comment suggestions as real diffs
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2020

df139f044b9b Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Author
epriestley
Browse Repository
No Builds
No Audits

acc1fa165519 Make "View as Document Type..." only show valid options
Author
epriestley
Browse Repository
No Builds
No Audits

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Browse Repository
No Builds
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

17426a60f00a Fix an issue where text intradiff bodies may not render
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 28 2020

befeb17f6ff1 Improve the construction of synthetic "comparison/intradiff" changesets
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 27 2020

aa20faeaa5d1 Fix an invalid index access for synthetic lint inline comments from Harbormaster
Author
epriestley
Browse Repository
No Builds
No Audits

c12db282519d For changesets that affect binaries, use the new binary file content hash as an…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 26 2020

b0c295e54509 Fix some PHP 7.4 array index access issues
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 25 2020

7355bb7f2956 Skip "null" lines when constructing raw documents for DocumentEngine rendering
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 22 2020

befbea2f00e6 Don't pass "No newline at end of file." annotations to DocumentEngines as…
Author
epriestley
Browse Repository
No Builds
No Audits

60de1506fe3b Make "hidden" changesets sticky, and show hidden state in the filetree
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 19 2020

c3c55d82ae9d Make "renderer", "engine", and "encoding" sticky across reloads in Differential…
Author
epriestley
Browse Repository
No Builds
No Audits

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 17 2020

3adf082002aa When inlines would disable a file shield in a diff, still apply the shield if…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 12 2020

f9b3e3360b0c Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 26 2019

292f8fc612bd Fix an issue where added or removed source files could incorrectly select a…
Author
epriestley
Browse Repository
No Builds
No Audits

8ff0e3ab351f Support rich diff rendering with DocumentEngine for added/removed files
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 1 2019

9f7aaa8ee4cb Fix an issue where any diff which could possibly be rendered as Jupyter decided…
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 30 2019

d9515e82a3ec Perform basic block interdiffs when diffing abstract blocks, and interdiff…
Author
epriestley
Browse Repository
No Builds
No Audits

5afdc620db59 Make basic Juypter notebook rendering improvements and roughly support folding…
Author
epriestley
Browse Repository
No Builds
No Audits

a7f3316aa3df Improve sequencing of various content/header checks in abstract block diffs
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 25 2019

1c4450d39f9b Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…
Author
epriestley
Browse Repository
No Builds
No Audits

7ae711ed3e0b Add a "View as..." option to diff dropdowns for selecting between document…
Author
epriestley
Browse Repository
No Builds
No Audits

bb71ef6ad6cd Render image diffs as abstract blocks diffs via DocumentEngine
Author
epriestley
Browse Repository
No Builds
No Audits

a73f592d7d08 Allow DocumentEngine to elect into diff construction
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2019

6bff2cee22fc Improve the performance of tab replacement in common cases
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 19 2019

fe7047d12d69 Display some invisible/nonprintable characters in diffs by default
Author
epriestley
Browse Repository
No Builds
No Audits

3f8eccdaec8f Put some whitespace behaviors back, but only for "diff alignment", not display
Author
epriestley
Browse Repository
No Builds
No Audits

5310f1cdd90e Remove all whitespace options/configuration everywhere
Author
epriestley
Browse Repository
No Builds
No Audits

661c758ff9d1 Render indent depth changes more clearly
Author
epriestley
Browse Repository
No Builds
No Audits

92abe3c8fb84 Extract scope line selection logic from the diff rendering engine so it can…
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 26 2018

bcc90d8c6b8c Fix an off-by-one error affecting mail rendering of inlines on the final line…
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2018

79fdf5c12707 Separate changeset analysis code from DifferentialDiff and provide a standalone…
Author
epriestley
Browse Repository
No Builds
No Audits

May 5 2018

af295341c863 Classify changesets as "generated" at creation time, in addition to display time
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 9 2017

9bd6a3705559 Fix spelling
Author
Dmitri Iouchtchenko
Browse Repository
No Builds
No Audits

Jun 12 2017

283a95d2aae0 Build a page for viewing all inline comments
Author
Chad Little
Browse Repository
No Builds
No Audits

Jun 2 2016

edfc6a69345a Convert some loadPreferences() to getUserSetting()
Author
epriestley
Browse Repository
No Builds
No Audits

May 30 2016

92ea4fb098cb Stop two special cache writes in read-only mode
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2016

bd9bcaa8ffea Improve HTML mail rendering of inline patches
Author
epriestley
Browse Repository
No Builds
No Audits

May 5 2016

1baef494c1b7 Pick context windows for inlines in a slightly smarter way
Author
epriestley
Browse Repository
No Builds
No Audits

94c7bb605c35 Highlight inline diff context in HTML mail
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 10 2016

68b468a846c1 Partially improve threading UI for adjacent inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 6 2015

f2435fd1d0b5 Return `$this` from setter methods
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Jun 15 2015

b6d745b66687 Extend from Phobject
Author
Joshua Spence
Browse Repository
No Builds
No Audits

May 25 2015

1b12249b2ca3 Fix some format strings
Author
Joshua Spence
Browse Repository
No Builds
No Audits

May 22 2015

36e2d02d6ec5 phtize all the things
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Apr 21 2015

84f62bdf9a79 Move ported inlines which appear on nonvisible lines backward so they show up
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 27 2015

174cf8239802 Provide getObjectOwnerPHID() on inline comment views
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 24 2015

aa310230b6bc Detect moves and copies with some unchanged lines as moves or copies
Author
epriestley
Browse Repository
No Builds
No Audits

373aaa643a51 Clean up copy detection code a bit
Author
epriestley
Browse Repository
No Builds
No Audits

21826ed7b35a Don't highlight very large files by default
Author
epriestley
Browse Repository
No Builds
No Audits

4310c4ed5387 Track a "Done" state on inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 9 2015

10a84d66dbc9 Show a more tailored message when adding empty files
Author
epriestley
Browse Repository
No Builds
No Audits

c35cafda2c2f Use ChangesetListView on Differential standalone view
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 5 2015

ad3c94dd454f Make "Show Context" persist rendering, whitespace, encoding, etc
Author
epriestley
Browse Repository
No Builds
No Audits

c82066408d1b Expand Differential test coverage to include moves, shields, and more
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 10 2015

d66cbff29811 Rename a constant
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Feb 9 2015

c66954af262f Fix a TODO
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Jan 30 2015

77eae81e1a5c Policy - fix up DifferentialChangesetParser
Author
Bob Trahan
Browse Repository
No Builds
No Audits

Dec 30 2014

39ca2fdf649f Use `new FutureIterator` instead of `Futures`
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Nov 17 2014

dc1106a9b910 Differential - stop showing the shield for "move away" operations
Author
Bob Trahan
Browse Repository
No Builds
No Audits

Aug 13 2014

1ad0e845188a Show image dimensions and some other metadata in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 9 2014

8756d82cf6c1 Remove `@group` annotations
Author
Joshua Spence
Browse Repository
No Builds
No Audits

Jun 29 2014

add7bc418dcb Allow Herald to "Require legal signatures" for reviews
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 20 2014

b20884a842a6 Substantially support character encodings and "Highlight As" in changesets
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 9 2014

0a62f13464b8 Change double quotes to single quotes.
Author
Joshua Spence
Browse Repository
No Builds
No Audits

May 19 2014

b64407d47e18 Fix explosive runtime of detectCopiedCode()
Author
epriestley
Browse Repository
No Builds
No Audits

May 17 2014

d744d5d85995 Fix binary/utf8 issues with Differential changeset parse cache
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 30 2013

13dae0519368 Make most file reads policy-aware
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 12 2013

ab2ae9e47fa3 Differential - make sure not to return change type header if we're not top level
Author
Bob Trahan
Browse Repository
No Builds
No Audits

Aug 30 2013

11f1268e993f don't throw BadMethodCallException on diffs that add images
Author
Wez Furlong
Browse Repository
No Builds
No Audits

Jun 28 2013

0529acd05b5c Fix typo in comment
Author
Jakub Vrana
Browse Repository
No Builds
No Audits

Feb 19 2013

a22bea2a74cf Apply lint rules to Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 13 2013

4f42d85c1c09 Use a serialize()-based cache instead of a JSON-based cache for changesets
Author
epriestley
Browse Repository
No Builds
No Audits

4bd2ad9270ac Merge branch 'master' into phutil_tag
Author
epriestley
Browse Repository
No Builds
No Audits

4eb84149c2f1 Convert everything to safe HTML
Author
vrana
Browse Repository
No Builds
No Audits

Feb 9 2013

b72e7969a1e0 Move Pygments handling to libphutil
Author
vrana
Browse Repository
No Builds
No Audits

Jan 19 2013

3e6fa4365811 getConfigEnv fails fast when key is not found and no default value is given.
Author
Nick Pellegrino
Browse Repository
No Builds
No Audits

Jan 16 2013

df8d0a578bbd Correctly handle unset generated paths
Author
vrana
Browse Repository
No Builds
No Audits

e974ffea7fc9 Remove curly braces around line count.
Author
Ricky Elrod
Browse Repository
No Builds
No Audits

Jan 15 2013

4566b86376bf Fix two diff rendering bugs
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 14 2013

2de107f21b2c Remove DifferentialChangesetRenderer->(g|s)etLineCount()
Author
epriestley
Browse Repository
No Builds
No Audits

612b29fff40a Implement basic one-up and test renderers
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 11 2013

dbdb01f85807 Fix whitespace and unchanged file shields
Author
epriestley
Browse Repository
No Builds
No Audits

039a5a6d8618 Simplify hunk parsing
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 10 2013

6a6910835874 Simplify context parsing and add test coverage
Author
epriestley
Browse Repository
No Builds
No Audits

9aeebbbf58ec Fix "context not available" in contextless diffs
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 9 2013

f1d7c8fbf8bd fix whitespace mode for differentialHunkParser
Author
Bob Trahan
Browse Repository
No Builds
No Audits

84c27ae255dc re-factor DifferentialChangesetParser pass 3 / N
Author
Bob Trahan
Browse Repository
No Builds
No Audits