HomePhorge
Diffusion Phorge f1d7c8fbf8bd

fix whitespace mode for differentialHunkParser
f1d7c8fbf8bd
Actions

Description

fix whitespace mode for differentialHunkParser

Summary: I forgot to "set it" from the changeset parser.

Test Plan: made a diff with silly whitespace changes. toggled the various whitespace modes and got appropriate results

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D4378

Details

Provenance
Bob TrahanAuthored on Jan 9 2013, 1:28 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP84c27ae255dc: re-factor DifferentialChangesetParser pass 3 / N
Branches
Loading...
Tags
Loading...

Event Timeline

Changes (2)

PathSize
src/
applications/
differential/
parser/

rPf1d7c8fbf8bd

View Options

src/applications/differential/parser/DifferentialChangesetParser.php

Loading...
View Options

src/applications/differential/parser/DifferentialHunkParser.php

Show All 39 Lines public function getIntraLineDiffs() {
return $this->intraLineDiffs; return $this->intraLineDiffs;
} }
public function setWhitespaceMode($white_space_mode) { public function setWhitespaceMode($white_space_mode) {
$this->whitespaceMode = $white_space_mode; $this->whitespaceMode = $white_space_mode;
return $this; return $this;
} }
private function getWhitespaceMode() { private function getWhitespaceMode() {
if ($this->whitespaceMode === null) {
throw new Exception(
'You must setWhitespaceMode before accessing this data.'
);
}
return $this->whitespaceMode; return $this->whitespaceMode;
} }
private function setSkipIntraLines($skip_intra_lines) { private function setSkipIntraLines($skip_intra_lines) {
$this->skipIntraLines = $skip_intra_lines; $this->skipIntraLines = $skip_intra_lines;
return $this; return $this;
} }
public function getSkipIntraLines() { public function getSkipIntraLines() {
▲ Show 20 Lines • Show All 94 Lines • ▼ Show 20 Linesfinal class DifferentialHunkParser {
* calculates what lines - if any - should be skipped within a diff display, * calculates what lines - if any - should be skipped within a diff display,
* ostensibly because they don't have anything to do with the current set * ostensibly because they don't have anything to do with the current set
* of changes with respect to display options. * of changes with respect to display options.
* *
* Anyhoo, this function is not particularly well-named but I try. * Anyhoo, this function is not particularly well-named but I try.
* *
* NOTE: this function must be called after * NOTE: this function must be called after
* @{method:parseHunksForLineData}. * @{method:parseHunksForLineData}.
* NOTE: you must @{method:setWhitespaceMode} before calling this method.
*/ */
public function reparseHunksForSpecialAttributes() { public function reparseHunksForSpecialAttributes() {
$rebuild_old = array(); $rebuild_old = array();
$rebuild_new = array(); $rebuild_new = array();
$skip_intra = array(); $skip_intra = array();
$old_lines = array_reverse($this->getOldLines()); $old_lines = array_reverse($this->getOldLines());
$new_lines = array_reverse($this->getNewLines()); $new_lines = array_reverse($this->getNewLines());
▲ Show 20 Lines • Show All 493 Lines • Show Last 20 Lines