HomePhorge

Don't pass "No newline at end of file." annotations to DocumentEngines as…

Description

Don't pass "No newline at end of file." annotations to DocumentEngines as literal diff text

Summary: See PHI1707, which has a Jupyter notebook which fails to diff nicely when modified. The root cause seems to be that the document does not end in a newline.

Test Plan: Applied patch, diffed the file, got a Jupyter diff out of it.

Differential Revision: https://secure.phabricator.com/D21159

Details

Provenance
epriestleyAuthored on Apr 22 2020, 8:20 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP60de1506fe3b: Make "hidden" changesets sticky, and show hidden state in the filetree
Branches
Unknown
Tags
Unknown

Event Timeline