HomePhorge

Fix an off-by-one error affecting mail rendering of inlines on the final line…

Description

Fix an off-by-one error affecting mail rendering of inlines on the final line of a file

Summary: Depends on D19837. Ref T13216. See PHI985. There's an off-by-one error here between how inline comments store "length" and how context rendering treats "length". We need to add 1 to the length, but currently do it a little too early. Do it slightly later so that inlines on the final line of a file render properly.

Test Plan: Left an inline on the final line of a new file, saw it render properly in HTML mail.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13216

Differential Revision: https://secure.phabricator.com/D19838

Details

Provenance
epriestleyAuthored on Nov 25 2018, 3:39 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP97e7ef0f015c: When the last rejecting reviewer resigns from a revision, return it to "Needs…
Branches
Loading...
Tags
Loading...

Event Timeline