Diffusion Phorge (master) History

phorge/src/infrastructure/diff/PhabricatorInlineCommentController.php
master1308a5555fee7b5d32fb127…

Mar 29 2021

1308a5555fee Update client logic for inline comment "Save" and "Cancel" actions
Author
epriestley
Browse Repository
No Builds
No Audits

6fd55d692f14 Formally track "initial", "committed", and "active" states for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

b75517918d86 When creating an inline comment, populate the content state with the default…
Author
epriestley
Browse Repository
No Builds
No Audits

d30c3a961cd9 Make the client authoritative for "Cancel" actions
Author
epriestley
Browse Repository
No Builds
No Audits

60e869f4114f Make the client authoritative for "Save" actions
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 19 2020

bc4f86d27996 When a new, deleted, draft inline is revived with "Undo", undelete it
Author
epriestley
Browse Repository
No Builds
No Audits

May 20 2020

846562158aae Roughly support inline comment suggestions
Author
epriestley
Browse Repository
No Builds
No Audits

00430fdbe117 Make server components of inline comment content handling state-oriented
Author
epriestley
Browse Repository
No Builds
No Audits

87bc30526b7a Make inline content "state-oriented", not "string-oriented"
Author
epriestley
Browse Repository
No Builds
No Audits

May 13 2020

2f5398796e02 Store inline comment offset information and show it when highlighting comments
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2020

0cca40db3bc6 When creating an inline, save the current document engine
Author
epriestley
Browse Repository
No Builds
No Audits

May 8 2020

fa2d30ee3698 Lift inline comment draft behaviors to "InlineController"
Author
epriestley
Browse Repository
No Builds
No Audits

May 7 2020

af5b94b23473 Lift most "InlineController" querying to the base class
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

07e160bde1e8 When cancelling an unsaved editing inline after a reload, don't cancel into an…
Author
epriestley
Browse Repository
No Builds
No Audits

fe501bd7f736 Save drafts for inline comments currently being edited
Author
epriestley
Browse Repository
No Builds
No Audits

63bfad0ff476 Refine unusual inline comment client interactions
Author
epriestley
Browse Repository
No Builds
No Audits

b2ce0844b6ff When a user clicks "Cancel" on an inline comment to leave the "Editing" state…
Author
epriestley
Browse Repository
No Builds
No Audits

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 7 2018

2a03367a50c0 When authors add inlines to their own revisions/commits, mark them as "Done" by…
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 6 2018

650e74933abb Update some inline comment logic to use more modern "Viewer"-oriented…
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2017

41379f39debb Move inline replies to new code and remove DifferentialInlineEditor
Author
epriestley
Browse Repository
No Builds
No Audits

3c18cb77fb66 Move inline "done" checkboxing to DiffInline
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 10 2016

8858b6cf8d17 When replying to a ghost comment, attach the reply to the same place
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 10 2015

093a6256984c Show users what's wrong when they try to edit an inline with an editor already…
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 21 2015

f1222f956a85 Correctly clear draft markers when deleting an inline comment
Author
epriestley
Browse Repository
No Builds
No Audits

May 27 2015

e9f4a84a892c Allow inline comments to be individually hidden
Author
epriestley
Browse Repository
No Builds
No Audits

May 8 2015

7c96ba4ced48 Fix another "reply" issue with inlines showing up on the wrong side
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 21 2015

c596c358db11 Make "Reply" on ghost inlines work correctly (or, at least, consistently)
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 27 2015

a17542ab28c2 Touch up PHP/JS interactions for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

174cf8239802 Provide getObjectOwnerPHID() on inline comment views
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 24 2015

4310c4ed5387 Track a "Done" state on inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 9 2015

dd501117e80c When deleting inline comments, offer "undo" instead of prompting
Author
epriestley
Browse Repository
No Builds
No Audits

daa893e50876 Extend TransactionCommentQuery for Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

4d86d51125fe Prepare TransactionCommentQuery for extension
Author
epriestley
Browse Repository
No Builds
No Audits

2972894a4df9 Write "hasReplies" to database for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

f1f2c5d01df1 Reduce code duplication in inline right/left side tracking
Author
epriestley
Browse Repository
No Builds
No Audits

355142fcbf23 Reduce code duplication on comment editing UI
Author
epriestley
Browse Repository
No Builds
No Audits

082b7f95e6e6 Explicitly track inline comment reply threading
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 7 2015

1df321bf00a1 Fix left/right detection of inline comments in unified view
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 6 2015

1352be827e12 Begin separating inline comment scaffolding from other renderers
Author
epriestley
Browse Repository
No Builds
No Audits

1088d34e58eb Rename inline comment views to "PHUIDiff" and give them a base class
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 5 2015

9564b0a40e88 Improve behavior of inline rendering with unified views
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 16 2014

baa998faa41a Disable full screen mode for inline comments
Author
Gareth Evans
Browse Repository
No Builds
No Audits

Feb 28 2014

3a188de32876 Align textarea in diff comment
Author
Chad Little
Browse Repository
No Builds
No Audits

Feb 21 2014

92ac8b5ad9a5 Make Differential inline comment rendering more consistent and somewhat more…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 18 2014

dcd7a316d239 Differential - add DifferentialDraft to track whether revisions have draft…
Author
Bob Trahan
Browse Repository
No Builds
No Audits

Jan 14 2014

42d9fa34e21b Use RemarkupControl in Differential inline comment UI
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 9 2013

fd8d9ff0d689 Replace some hsprintf() with phutil_tag() and phutil_tag_div() Depends on D7545.
Author
Jakub Vrana
Browse Repository
No Builds
No Audits

Feb 13 2013

ef7f16180ce5 Restore merge of phutil_tag.
Author
epriestley
Browse Repository
No Builds
No Audits

73cce6e1310b Revert "Promote phutil-tag again"
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 9 2013

58b6e2cac641 Convert AphrontDialogView to safe HTML
Author
vrana
Browse Repository
No Builds
No Audits

Jan 25 2013

3093d1663de4 Add javelin_tag(), convert easy callsites
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 5 2012

ef85f49adc07 Delete license headers from files
Author
vrana
Browse Repository
No Builds
No Audits

Oct 23 2012

fdf90b46eb88 Use modern two-stage markup cache (PhabricatorMarkupInterface) in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 4 2012

8ff52c0b6ca1 Set viewer for all handles loaded in controllers
Author
vrana
Browse Repository
No Builds
No Audits

Jun 1 2012

6cc196a2e557 Move files in Phabricator one level up
Author
vrana
Browse Repository
No Builds
No Audits