HomePhorge

Explicitly condition Differential draft promotion on only "impactful" builds

Description

Explicitly condition Differential draft promotion on only "impactful" builds

Summary:
Depends on D19281. This increases consistency between build timeline publishing and revision draft promotion.

There's no real behavioral change here (switching how publishing worked already changed the beahvior) but this sends more callsites down the same code paths.

Since the builds we're looking at include completed builds, change the term "active" to "impactful". This describes the same set of builds, but hopefully describes them more accurately.

Test Plan: Created a local revision, saw it plausibly interact with draft status and promote. There are a lot of moving parts here and some stuff may well have slipped through.

Differential Revision: https://secure.phabricator.com/D19282

Details

Provenance
epriestleyAuthored on Apr 3 2018, 7:54 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP51461f18c15b: When publishing buildables in Differential, ignore autobuilds (local lint and…
Branches
Loading...
Tags
Loading...

Event Timeline