Diffusion Phorge (master) History

phorge/src/applications/files
masterabeeadd6b01318150ae3c1e…

Feb 3 2025

6facee6140ea Communicate max dimensions of profile images before upload
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Oct 24 2024

5f4587bb88dd Fix implicitly nullable parameter declarations for PHP 8.4
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Oct 23 2024

db61eb20f0f0 Fix implicitly nullable parameter declarations for PHP 8.4
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Oct 22 2024

b08c7c761c10 Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Sep 9 2024

aa2b70708e2f PHPDoc: Replace "@return this" with "@return $this"
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Sep 6 2024

123831b53fb7 Drop question mark suffix from optional PHPDoc @param types
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Sep 4 2024

43539b220ce2 Remove trivial cases of unreachable code
Author
Andre Klapper
Browse Repository
No Builds
No Audits

8c3a62d6afd0 Fix PHP 8.1 "strlen(null)" exception rendering a File's default Alt text
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Aug 21 2024

b44b566b1334 Add missing variable names to PHPDoc @param of methods
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Aug 10 2024

2b7c0ec92f6c Destroy file attachments when file is deleted, or object is deleted
Author
Dylan F
Browse Repository
No Builds
No Audits

Aug 7 2024

b74f1ad519e8 Fix 404 link in Diviner to "Configuring File Storage" article
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Aug 3 2024

d8b94dd87d24 Misc PHPDoc additions to PhabricatorFile
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jun 5 2024

98884f758a29 Fix call to non-existing newIcons() in PhabricatorIconSet
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 15 2024

50d0bbe8ff68 Fix PHP 8.1 "strlen(null)" exception rendering files/documents
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Apr 29 2024

3367fe0017b1 Drag & Drop Task Cover Image: also attach
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

Apr 17 2024

98cbf5fa19e2 Fix PHP 8.1 "strlen(null)" exception for "/bin/files encode" without --as…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

0bdfcc47e7de Fix PHP 8.1 "strlen(null)" exception for "/bin/files migrate" without parameter
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Apr 16 2024

05798a630120 Fix PHP 8.1 "strlen(null)" exception for "/bin/files generate-key" without…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Feb 5 2024

25aebab655fd Make misc get*ApplicationClass[Name]() calls return ::class constant instead of…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jan 28 2024

064424c1b755 Add getQueryApplicationClass() to *TransactionQuery.php classes
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jan 23 2024

7a86040f8a46 Avoid exception setting project profile image when GD not installed
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jan 17 2024

7702772b2b86 preg_match() null exception setting custom user profile image with empty files.
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Dec 27 2023

428f9686c417 Composing a custom project picture: Remove misaligned empty icon
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Dec 17 2023

fe1122bd4d6d Catch RuntimeException: mb_convert_encoding(): Illegal character encoding…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Nov 28 2023

c3850a3c1530 Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Nov 21 2023

1b49165ddd16 Show more in Application Detail and List view
Author
Matthew Bowker
Browse Repository
No Builds
No Audits

Nov 12 2023

16d9cc12af45 Enforce viewable MIME types config on PDF documents
Author
Zero King
Browse Repository
No Builds
No Audits

Nov 11 2023

005fea5a14f4 Fix view policy inheritance on image transforms
Author
David Lawrence
Browse Repository
No Builds
No Audits

Jul 17 2023

27fa49896622 Fix PHP 8.1 strlen(null) error in PhabricatorFile::newChunkedFile()
Author
Steve Campbell
Browse Repository
No Builds
No Audits

Jul 5 2023

f45d6421a13c Fix PHP 8.1 "strlen(null)" exception opening a File overlay (Lightbox comment…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Jun 11 2023

108cbcd09bd3 Fix PHP 8.1 "base64_decode(null)" exception calling Conduit's file.upload with…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 23 2023

3999a286741d Fix PHP 8.1 exceptions which block adding an embedded File preview as a Comment
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 12 2023

c2856b479fbd Fix PHP 8.1 "implicit conversion from float to int" exception on certain avatar…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 5 2023

651e3f7263b5 Fix PHP 8.1 "strlen(null)" exception which blocks rendering a File page when…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

6c692ddbbba8 Fix PHP 8.1 "strlen(null)" exceptions which block rendering page of a File
Author
Andre Klapper
Browse Repository
No Builds
No Audits

May 1 2023

8f669ea08289 Fix PHP 8.1 "strlen(null)" exceptions which block rendering the People page
Author
Andre Klapper
Browse Repository
No Builds
No Audits

5a76e8d26232 Fix PHP 8.1 "strlen(null)" exception which blocks loading icons when creating…
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Apr 27 2023

b56d86e48d0f Fix numerous PHP 8.1 "strlen(null)" exceptions preventing homepage to display
Author
Andre Klapper
Browse Repository
No Builds
No Audits

Mar 31 2023

d25d630fe5dd PHP 8.2: fixes for strlen() not accepting NULL anymore, part 1
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

May 25 2022

7e5f7b96404f Update "Files" attachment table to show more attachment details and support…
Author
epriestley
Browse Repository
No Builds
No Audits

May 24 2022

8e703c8c351d Provide a default "loadPage()" implementation on "CursorPagedPolicyAwareQuery"
Author
epriestley
Browse Repository
No Builds
No Audits

5493f028dca6 Provide a simple "Attach File" explicit workflow for files referenced but not…
Author
epriestley
Browse Repository
No Builds
No Audits

May 23 2022

021e5ab933e4 Provide a rudimentary "Attached Files" curtain UI panel
Author
epriestley
Browse Repository
No Builds
No Audits

5033ef6f88b3 Give "FileAttachment" policy support and a query object
Author
epriestley
Browse Repository
No Builds
No Audits

631c36aee326 Don't consider file references inside quoted text blocks to grant "attachment…
Author
epriestley
Browse Repository
No Builds
No Audits

May 19 2022

fee8297121f0 Remove file attachment edge types, including API access
Author
epriestley
Browse Repository
No Builds
No Audits

b872640c160a Remove all "FileHasObject" edge reads and writes
Author
epriestley
Browse Repository
No Builds
No Audits

c25a8fabfc1e Remove all "ObjectHasFile" edge reads and writes
Author
epriestley
Browse Repository
No Builds
No Audits

d017f3f21021 Double-write file attachment to old "edge" storage and new "attachment" storage
Author
epriestley
Browse Repository
No Builds
No Audits

7fcc0f9ebd91 Remove "PhabricatorFile->detachFromObject()"
Author
epriestley
Browse Repository
No Builds
No Audits

cfa42c5e655c Add database storage for a dedicated file attachment table
Author
epriestley
Browse Repository
No Builds
No Audits

ee6e2a396fec Fix some test suite stragglers with PHP 8.1 compatibility
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 25 2022

2f4ac2a8040a Remove product literal strings in "pht()", part 19
Author
epriestley
Browse Repository
No Builds
No Audits

ad880491e8d6 Remove product literal strings in "pht()", part 5
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 16 2021

6136964093cb Fix a PHP 8.1 strlen() issue with "mysql.pass" configuration
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 11 2021

4484946cfd29 In JSON DocumentEngine, preserve the distinction between "{}" and "[]"
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 4 2021

bfe7cdc5a2af Provide default image alt text in more contexts and support custom alt text
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 16 2020

058d2489e7a3 Expose the "file attached to object" and "object attached to file" edges via…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 5 2020

2db1955159f7 In Jupyter notebooks, read strings stored in the raw as either "string" or…
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2020

4fd0628fae45 Fix two rendering issues with Jupyter notebooks
Author
epriestley
Browse Repository
No Builds
No Audits

May 12 2020

df139f044b9b Render proper "Show Context" links in DocumentEngine diffs, not just bullets
Author
epriestley
Browse Repository
No Builds
No Audits

May 1 2020

eab561bb8790 Add "uri" to the API results for File objects
Author
epriestley
Browse Repository
No Builds
No Audits

fbbd2e35cb46 Make content more prominent in Files and move some details to the curtain
Author
epriestley
Browse Repository
No Builds
No Audits

3c1f393c812f When a Paste has a useful alternative rendering in Files, provide a hint
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 15 2020

3573170dfacb Compress file downloads if the client sends "Accept-Encoding: gzip" and we…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 14 2020

64cc4fe91515 Add a test to verify that all routing maps are plausibly valid, and remove some…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 12 2020

f9b3e3360b0c Continue moving classes with no callers in libphutil or Arcanist to Phabricator
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 30 2020

ccf28a81121e Fix an issue where the last line of block-based diffs could be incorrectly…
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 26 2019

8ff0e3ab351f Support rich diff rendering with DocumentEngine for added/removed files
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 2 2019

344a2e39bed7 In Jupyter notebooks, apply intraline diffing to source code lines
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 30 2019

d9515e82a3ec Perform basic block interdiffs when diffing abstract blocks, and interdiff…
Author
epriestley
Browse Repository
No Builds
No Audits

5afdc620db59 Make basic Juypter notebook rendering improvements and roughly support folding…
Author
epriestley
Browse Repository
No Builds
No Audits

a7f3316aa3df Improve sequencing of various content/header checks in abstract block diffs
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 25 2019

2c06815edb0f When rendering Jupyter notebook diffs, split code inputs into individual blocks
Author
epriestley
Browse Repository
No Builds
No Audits

884cd74cc4a5 In prose diffs, use hash-and-diff for coarse "level 0" diffing to scale better
Author
epriestley
Browse Repository
No Builds
No Audits

281598d65cfc Use a hash-and-diff strategy to produce a diff layout for block-based documents
Author
epriestley
Browse Repository
No Builds
No Audits

1c4450d39f9b Allow the Jupyter engine to elect to emit diffs, and emit Jupyter documents as…
Author
epriestley
Browse Repository
No Builds
No Audits

bb71ef6ad6cd Render image diffs as abstract blocks diffs via DocumentEngine
Author
epriestley
Browse Repository
No Builds
No Audits

a73f592d7d08 Allow DocumentEngine to elect into diff construction
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 19 2019

2ee5e71029af Simplify implementation of "SysetemAction->getSystemActionConstant()"
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 24 2019

da0dfc057d64 Make "bin/files" parsing of working set arguments more consistent
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 15 2019

64a95000788d Add "bin/file migrate" options to support import of a local-disk backup for…
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 14 2019

5892c7898603 Replace all "setQueryParam()" calls with "remove/replaceQueryParam()"
Author
epriestley
Browse Repository
No Builds
No Audits

241f06c9ffc6 Clean up final `setQueryParams()` callsites
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 17 2019

c125ab7a42bf Remove "metamta.*.subject-prefix" options
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 16 2019

e3aa043a0272 Allow multiple mail receivers to react to an individual email
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 4 2019

dda3ff89e06d Consolidate some application email receiver code in preparation for API changes
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 20 2018

11cf8f05b176 Remove "getApplicationTransactionObject()" from ApplicationTransactionInterface
Author
epriestley
Browse Repository
No Builds
No Audits

937e88c399ab Remove obsolete, no-op implementations of "willRenderTimeline()"
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 15 2018

86fd2041484f Fix all query warnings in "arc unit --everything"
Author
epriestley
Browse Repository
No Builds
No Audits

98690ee326ce Update many Phabricator queries for new %Q query semantics
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 3 2018

91abc0f02720 Stop indexing the chunk data objects for large Files stored in multiple chunks
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 27 2018

cb99396c64dc Make the "Is this JSON?" DocumentEngine heuristic a little tighter
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 26 2018

682c3bc9ee56 When migrating files between storage engines with "bin/files migrate ...", skip…
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 23 2018

6bdd74584ef3 Fix file encoding migration
Author
Kenneth Endfinger
Browse Repository
No Builds
No Audits

May 4 2018

5784e3d3c0cf Omit "type" attribute from "<source />" tags in "<video>" to trick Chrome into…
Author
epriestley
Browse Repository
No Builds
No Audits

May 1 2018

332f4ab66d18 Restore support for using "arc download" to fetch files with no "security.
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 30 2018

afc3099ee785 Add a view option to disable blame in Diffusion and fix some view transition…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 27 2018

223d7b84dd18 Recover more gracefully when favicon configuration points at a corrupt/damaged…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 17 2018

665529ab60a1 Restore coverage reporting to Diffusion browse UI
Author
epriestley
Browse Repository
No Builds
No Audits