HomePhorge

Fix implicitly nullable parameter declarations for PHP 8.4

Description

Fix implicitly nullable parameter declarations for PHP 8.4

Summary:
Implicitly nullable parameter declarations are deprecated in PHP 8.4:
https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

The proposed syntax was introduced in PHP 7.1.

Note: This code change does *not* fix all occurrences but only allows passing ./bin/storage upgrade.

Refs T15935

Test Plan: Try to successfully run ./bin/storage upgrade with PHP 8.4

Reviewers: O1 Blessed Committers, chris

Reviewed By: O1 Blessed Committers, chris

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15935

Differential Revision: https://we.phorge.it/D25814

Details

Provenance
Andre KlapperAuthored on Aug 30 2024, 7:37 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rPb08c7c761c10: Fix PHP 8.1 "strlen(null)" exception rendering JSON file as Jupyter
Branches
Unknown
Tags
Unknown

Event Timeline