HomePhorge

Fix PHP 8.1 "strlen(null)" and "preg_match()" exceptions which block repository…

Description

Fix PHP 8.1 "strlen(null)" and "preg_match()" exceptions which block repository creation

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Similarly, preg_match() does not accept passing null as $subject parameter since PHP 8.1.

Closes T15337

Test Plan: Applied these four changes and /diffusion/4/manage/ finally rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15337

Differential Revision: https://we.phorge.it/D25182

Details

Provenance
Andre KlapperAuthored on May 19 2023, 8:18 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP912a933b0214: Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures
Branches
Loading...
Tags
Loading...

Event Timeline