HomePhorge

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures

Description

Fix PHP 8.1 "strlen(null)" exceptions which block rendering Legalpad signatures

Summary:
strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Closes T15395

Test Plan: Applied these two changes; afterwards "All Signatures" page at /legalpad/signatures/1/ gets rendered in web browser.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15395

Differential Revision: https://we.phorge.it/D25226

Details

Provenance
Andre KlapperAuthored on May 19 2023, 8:01 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP26aed4935b55: Fix PHP 8.1 "strlen(null)" exception shown when sending SMS Test Message to…
Branches
Unknown
Tags
Unknown

Event Timeline