Fix notification message when Aphlict is not configured
Summary:
Before this change the footer in the notification bar was a bit
weird on the message "Notification server not enabled":
| Before | After |
|---|---|
| {F315024} | {F315001} |
Also a bit wrong on the "Connecting..." message:
| Before | After |
|---|---|
| {F315061} | {F315072} |
The fix involves a refactor in the HTML structure in order to
match the graphic rendered when Aphlict is configured and running.
In short, we pass from this:
<span class="connection-status-text aphlict-connection-status-notenabled"> <span class="visual-only phui-icon-view phui-font-fa fa-circle-o grey"></span> Notification server not enabled </span>
To this:
<span class="visual-only phui-icon-view phui-font-fa fa-circle-o grey"></span> <span class="connection-status-text aphlict-connection-status-notenabled">Notification server not enabled</span>
See the Task for additional details.
Closes T15415
Test Plan:
Follow the official Notification documentation about the config notification.servers,
open the Notification top-bar, and check the message in these conditions:
- without the config
- with the config
- with/without Aphlict running
https://we.phorge.it/book/phorge/article/notifications/
Reviewers: O1 Blessed Committers, avivey
Reviewed By: O1 Blessed Committers, avivey
Subscribers: avivey, speck, tobiaswiese, Matthew, Cigaryno
Maniphest Tasks: T15415
Differential Revision: https://we.phorge.it/D25312