HomePhorge

Fix UX regression in Dashboard Tabs Panel

Description

Fix UX regression in Dashboard Tabs Panel

Summary:
Before this change, it seems that the Dashboard Tabs Panel could be empty
as default. This was the regression:

cbc0e661544a31290099ab3d88481bb8d4a3003c

The variable $is_selected was defined inside a foreach loop, but that loop
was terminated when it was then read again. This redefines that variable in
the right scope.

BeforeAfter
{F312797}{F312798}

Closes T15474

Test Plan: - see that now you have something visibile in your Dashboard Tabs Panel

Reviewers: speck, O1 Blessed Committers

Reviewed By: speck, O1 Blessed Committers

Subscribers: tobiaswiese, Matthew, Cigaryno

Maniphest Tasks: T15474, T15146

Differential Revision: https://we.phorge.it/D25291

Details

Provenance
Valerio BozzolanAuthored on Jun 26 2023, 11:14 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPe4fe54edf0d3: Fix typo "recipeint" in metamta.one-mail-per-recipient description
Branches
Unknown
Tags
Unknown

Event Timeline