Diffusion Phorge (master) History

phorge/src/applications/differential/xaction
master42a8b73adbaa1bb241abb71…

Mar 25 2023

42a8b73adbaa Feed Differential retitled: do not repeat the title twice
Author
Valerio Bozzolan
Browse Repository
No Builds
No Audits

Mar 3 2021

f3caf7e9fcd6 Improve rendering behavior for "foist upon" with an empty tokenizer
Author
epriestley
Browse Repository
No Builds
No Audits

dec14136844d Provide a more general "Author" transaction for Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 8 2020

6e1b5da1121c Fix additional "xprintf()"-class static parameter lint errors
Author
epriestley
Browse Repository
No Builds
No Audits

Jul 9 2020

1d4d860cb5a0 Allow non-authors to "Request Review" of draft revisions
Author
epriestley
Browse Repository
No Builds
No Audits

b21b73b8dd35 Expand Revision transaction API to allow actions to vary more broadly based on…
Author
epriestley
Browse Repository
No Builds
No Audits

May 4 2020

b48a22bf50a3 Make "editing" state persistent for inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

May 1 2020

b2cfcda114a4 Provide detailed information about reviewer changes in "transaction.search"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 19 2020

8aac55cc57cb Make "Highlight As..." sticky across reloads in Diffusion and Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 5 2020

f1d1ec3d77f1 Add an "isDone" flag to "transaction.search" for Differential inline comments
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 4 2019

760406762a6f When a revision is closed, always promote it out of draft
Author
epriestley
Browse Repository
No Builds
No Audits

May 22 2019

b95bf722d55e Drop the "update revision with commit diff" transaction if the revision is…
Author
epriestley
Browse Repository
No Builds
No Audits

fa4dcaa3aaff Stabilize sorting of feed stories with similar strength
Author
epriestley
Browse Repository
No Builds
No Audits

May 16 2019

4a3481a49384 Enrich "draft", "summary", and "testPlan" transactions from Differential in…
Author
epriestley
Browse Repository
No Builds
No Audits

May 1 2019

a15b0063df3d Add "Revision has passing builds" Herald rules for commit content (pushes) and…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 23 2019

7b8ac020b521 Change "Revision Close" story to use commit identities only with no fallback to…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 17 2019

5b6d6c4fb313 Use repository identities, not denormalized strings, to identify authors for…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 6 2019

7e4681234467 Add a warning to revision timelines when changes land with ongoing or failed…
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 26 2018

9473f60a362f Allow "Abandoned" revisions to be commandeered
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 16 2018

b2e91d220539 Move the "container updated" message for Buildables that build Diffs outside of…
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 15 2018

44c32839a68c When you "Request Review" of a draft revision, change the button text from…
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 28 2018

a94528ee4aa1 Expose Differential actions for "transaction.search" in a basic way
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 27 2018

9f8e0ad473a6 Remove unusual unicode marks in Differential action dropdown
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 23 2018

16af0d35e510 In Differential, prevent "Accept" and "Reject" from "Plan Changes + Draft"
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 12 2018

4068aaef61a0 Toggle revision "shouldBroadcast" correctly when "--draft" is used with…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 3 2018

f4f33113124f When reclaiming an "Abandoned + Draft" revision, return it to "Draft", not…
Author
epriestley
Browse Repository
No Builds
No Audits

adf8fdef0e89 When remote builds fail, demote revisions to "Changes Planned + But, Still A…
Author
epriestley
Browse Repository
No Builds
No Audits

d9bd36039fd1 When a non-broadcasting revision is updated, put it in "Draft", not "Needs…
Author
epriestley
Browse Repository
No Builds
No Audits

38e788c99a78 Partially decouple revision broadcasting from revision draft state
Author
epriestley
Browse Repository
No Builds
No Audits

51461f18c15b When publishing buildables in Differential, ignore autobuilds (local lint and…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 29 2018

79154455437b Fix two issues with Differential updates and Owners
Author
epriestley
Browse Repository
No Builds
No Audits

93cb6e3bdeb0 Make updating a revision with the same active diff a no-op
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 21 2018

73b68bc2a619 Fix a possible `count(null)` in DifferentialRevisionActionTransaction
Author
Tino Breddin
Browse Repository
No Builds
No Audits

Mar 14 2018

af8269d2fb06 Allow draft revisions to be commandeered
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 12 2018

1e93b49b1bf2 Allow custom actions in Differential to explicitly override "accept" stickiness
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 6 2018

e57dbcda336a Hide "abraham landed Dxyz irresponsibly" stories from feed
Author
epriestley
Browse Repository
No Builds
No Audits

f3928962096c Return commit information for Revision "close" and "update" transactions over…
Author
epriestley
Browse Repository
No Builds
No Audits

743d1ac426fb Mostly modularize the Differential "update" transaction
Author
epriestley
Browse Repository
No Builds
No Audits

Feb 12 2018

11c999413493 Allow "arc diff --plan-changes" to work with drafts enabled
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 5 2017

6d3baa92f908 Execute Herald again after promoting revisions out of the "Draft" state
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 30 2017

0807b70ea167 Add an explicit warning in the Differential transaction log when users skip…
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 28 2017

1b76250f8995 Disallow "Accept" on drafts, allow "Resign"
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 14 2017

95a5b41b0ba2 Allow "arc diff --draft" to create revisions as drafts more forcefully
Author
epriestley
Browse Repository
No Builds
No Audits

Nov 7 2017

cb98b6003326 Fill in some straightforward Maniphest transactions for `transaction.search`
Author
epriestley
Browse Repository
No Builds
No Audits

Oct 31 2017

28cec2f8a2bf Allow revisions to be held as drafts, even after builds finish
Author
epriestley
Browse Repository
No Builds
No Audits

Sep 21 2017

c7af663523e5 Align most revision actions to the new "Draft" state
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 29 2017

f49d103af5d3 Fix an issue where "Close Revision" did not appear in the UI
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 25 2017

213e4ec9b553 Add a missing (int) cast to diff IDs for new "transaction.search" method
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 24 2017

fa5bcf5d9478 Provide some more detailed information about inline comments in "transaction.
Author
epriestley
Browse Repository
No Builds
No Audits

6c9026c33a45 Allow ModularTransactions to opt in to providing data to Conduit
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 12 2017

48a74de0b649 Move all revision status transactions to modern values and mechanics
Author
epriestley
Browse Repository
No Builds
No Audits

7b695aa43bd1 Migrate revision storage to modern status constants ("accepted") instead of…
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 11 2017

5348f34c9eec Make all revision status readers explicitly read modern or legacy status
Author
epriestley
Browse Repository
No Builds
No Audits

cd15c2d545ad Swap transactions and initialization over to modern status constants
Author
epriestley
Browse Repository
No Builds
No Audits

2b9838b482af Modularize remaining TYPE_ACTION transactions in Differential, reducing calls…
Author
epriestley
Browse Repository
No Builds
No Audits

19bc91fd208d Modularize the Differential "status" transaction and move away from…
Author
epriestley
Browse Repository
No Builds
No Audits

77bf24563704 Continue reducing callsites to ArcanistDifferentialRevisionStatus in…
Author
epriestley
Browse Repository
No Builds
No Audits

ef8d4e2126af Fix an inverted condition for the "Reopen Revision" action
Author
epriestley
Browse Repository
No Builds
No Audits

153e4d8a383c Remove old reviewer double writes to legacy edge table in Differential
Author
epriestley
Browse Repository
No Builds
No Audits

Aug 9 2017

03ab7224bb4e Reduce STATUS_CLOSED (now internally "Published") revision status callsites
Author
epriestley
Browse Repository
No Builds
No Audits

Jun 30 2017

596b83a7122a Move misplaced validation for ambiguous fields in "Test Plan" to the right place
Author
epriestley
Browse Repository
No Builds
No Audits

May 25 2017

19572f53fdfe Don't consider accepting on behalf of valid-but-accepted reviewers to be a…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 10 2017

26d6096e0a5b When reviewing, always show "Accept" checkboxes for packages/projects, even if…
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 6 2017

f1eeaaf59f7f Fix scope of "Accept" when you don't check all the "Force Accept" boxes
Author
epriestley
Browse Repository
No Builds
No Audits

Apr 3 2017

9ebb5f8cda56 Don't downgrade accepts on update (fix "sticky accept")
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 28 2017

2fbc9a52da9b Allow users to "Force accept" package reviews if they own a more general package
Author
epriestley
Browse Repository
No Builds
No Audits

ddc02ce420a5 When voiding "Accept" reviews, also void "Reject" reviews
Author
epriestley
Browse Repository
No Builds
No Audits

aea46e55dac0 Fix an issue where "Request Review" of a fully-accepted revision would…
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 24 2017

24b6c7d7186a Allow users to resign if they have authority over any reviewer
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 22 2017

aa91dc992e24 Record which user accepted on behalf of packages/owners reviewers
Author
epriestley
Browse Repository
No Builds
No Audits

fab37aa4e35a When accepting revisions, allow users to accept on behalf of a subset of…
Author
epriestley
Browse Repository
No Builds
No Audits

891355297074 Store "resigned" as an explicit reviewer state
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 20 2017

0ceab7d36f91 Rename "getReviewerStatus()" to "getReviewers()"
Author
epriestley
Browse Repository
No Builds
No Audits

794b456530bc Store "last comment" and "last action" diffs on reviewers
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 14 2017

251ee9b660b8 Add dedicated "reviewers" storage to Differential and do double writes
Author
epriestley
Browse Repository
No Builds
No Audits

Mar 2 2017

0a0ac1302f02 Prevent users from taking "edit"-like actions via comment forms if they don't…
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 30 2017

e16080ce7e6c Fix typo in DifferentialRevisionCommandeerTransaction
Author
Sébastien Santoro
Browse Repository
No Builds
No Audits

Jan 25 2017

df939f1337fd Fix two issues with embedding other fields inside "Summary" or "Test Plan" in…
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 18 2017

269dd81f9178 Allow users to re-accept or re-reject a revision if they have authority over…
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 12 2017

7d3d0224071a Restore "[Action]" mail subject lines to Differential/Diffusion
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 9 2017

425deeb52391 Fix an issue which could prevent blocking reviewers from being removed from…
Author
epriestley
Browse Repository
No Builds
No Audits

Jan 2 2017

50de3071acaf Define Differential email action in terms of EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

35750b9c615a Make some Differential comment actions (like "Accept" and "Reject") conflict…
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 31 2016

f7b5955d3386 Order actions sensibly within Differential revision comment action groups
Author
epriestley
Browse Repository
No Builds
No Audits

48fcfeadafe2 Allow comment actions to be grouped; group Differential "Review" and "Revision"…
Author
epriestley
Browse Repository
No Builds
No Audits

5a6643f36ff8 Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

8b74cd481a47 Restore "Commandeer" action to Differential on EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

deb19b2d572d Restore "Plan Changes" and "Request Review" actions to Differential on…
Author
epriestley
Browse Repository
No Builds
No Audits

a90ab7f4033d Restore "Close" and "Reopen" actions to Differential on EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

3c5a17ba8a55 Restore "Reclaim" and "Abandon" actions to Differential on EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 16 2016

64509dcca7be Drive CLI-based revision edits through "differential.revision.edit" API +…
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 14 2016

378387a0785f Fix an issue with mentioning revisions on the new EditEngine code
Author
epriestley
Browse Repository
No Builds
No Audits

Dec 13 2016

7f99f2cde835 Add EditEngine + Modular Transactions for reviewers
Author
epriestley
Browse Repository
No Builds
No Audits

6c9af81f7adb Support "Test Plan" with modular transactions and EditEngine
Author
epriestley
Browse Repository
No Builds
No Audits

5349d6bd5c09 Add Summary and Repository EditEngine fields + Modular Transactions to…
Author
epriestley
Browse Repository
No Builds
No Audits

0906bf547b9a Begin adding "pro" modular transaction fields to Differential
Author
epriestley
Browse Repository
No Builds
No Audits