HomePhorge

Always ellipsize long filename in file upload dialog

Description

Always ellipsize long filename in file upload dialog

Summary:
Firefox does not ellipsize long filenames after selecting them in the File Upload dialog; Chromium does (for unknown reasons).

Could hardcode the "remaining" width for the <input> element itself (approx. 340px) based on calculating the CSS widths and margins of all surrounding elements but that is error-prone if CSS for one of those surrounding elements ever changed.
Thus instead use max-width: stretch for the <input> element itself. Per its limited support (see https://caniuse.com/?search=max-width), set also -moz-available (https://bugzilla.mozilla.org/show_bug.cgi?id=1495868) and -webkit-fill-available (see https://bugs.chromium.org/p/chromium/issues/detail?id=611857) aliases.

Closes T15553

Test Plan:

  • Both in Firefox and in Chromium, go to an existing task, select "File Upload", select a file with a long name.
  • See that the filename is now correctly ellipsized in Firefox.
  • See no changes in Chromium.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15553

Differential Revision: https://we.phorge.it/D25347

Details

Provenance
Andre KlapperAuthored on Jul 29 2023, 2:12 AM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP189a5d60478e: Fix strlen(null) PHP 8.1 error when pushing into a fresh repository
Branches
Unknown
Tags
Unknown

Event Timeline