HomePhorge

Modularize Almanac Binding transactions

Description

Modularize Almanac Binding transactions

Summary: Depends on D19320. Ref T13120. Ref T12414. Move transactions for Almanac Bindings to ModularTransactions.

Test Plan:

  • Created a new binding.
  • Tried to create a duplicate binding, got an error.
  • Edited a binding to rebind it to a different device.
  • Disabled and enabled bindings.
  • Grepped for AlmanacBindingTransaction:: constants.

When a binding is created, it currently renders a bad "changed the interface from ??? to X" transaction. This is because creation isn't currently using EditEngine. I plan to swap it shortly, which will turn this into a real "Create" transaction and fix the issue.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13120, T12414

Differential Revision: https://secure.phabricator.com/D19321

Details

Provenance
epriestleyAuthored on Apr 10 2018, 5:08 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP5ada1211cdeb: Modularize Almanac Namespace transactions
Branches
Unknown
Tags
Unknown

Event Timeline