HomePhorge

Refactor some Herald code

Description

Refactor some Herald code

Summary:
I was reading herald code for a task and realized that the method was
really long. So I refactor it to shorter methods.

Test Plan:
was still able to create a differential rule and commit rule; and
verified that dry-run still worked.

Reviewers: epriestley, tuomaspelkonen

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: 1077

Details

Provenance
Jason GeAuthored on Oct 21 2011, 6:34 PM
Jason GeCommitted on Nov 4 2011, 4:32 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPfbfb263cd9ef: Provide a configuration flag to disable silliness in the UI
Branches
Unknown
Tags
Unknown

Event Timeline