HomePhorge

Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the…

Description

Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the Aphlict server

Summary: Ref T5651. Only throw a HTTP 400 if the data is invalid (i.e. the request is bad). If something bad happens when trying to transmit the notification, throw a HTTP 500 instead.

Test Plan: Eye-ball it.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5651

Differential Revision: https://secure.phabricator.com/D9968

Details

Provenance
Joshua SpenceAuthored on Jul 17 2014, 4:20 PM
themackabuPushed on Tue, Mar 25, 8:07 PM
Parents
rP41a8837f78db: Make HTTP errors returned from the Aphlict server more specific
Branches
Unknown
Tags
Unknown

Event Timeline