HomePhorge

Set project's ObjectName to its PHID when it doesn't have a hashtag

Description

Set project's ObjectName to its PHID when it doesn't have a hashtag

Summary: Fixes T12659. Previously this would lead to an error when trying to run arc diff on a revision that had a milestone as a reviewer (or any non-octothorpe'd Object Name)

Test Plan: Followed repro steps in T12659 and didn't get the error described. Also clicked around and didn't notice any obvious regressions in projects or differential

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, yelirekim

Maniphest Tasks: T12659

Differential Revision: https://secure.phabricator.com/D17807

Details

Provenance
Josh CoxAuthored on Apr 5 2017, 3:08 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPb7c4f60e235d: Only recognize "Fixes ..." in main revision content like the Summary or Test…
Branches
Unknown
Tags
Unknown

Event Timeline