HomePhorge

Pholio - fix show older transactions for if there are inline comments

Description

Pholio - fix show older transactions for if there are inline comments

Summary: We didn't load enough data for this case for the custom view class Pholio uses. Fixes T6770. Re-jiggers the signature of the loadImages function in the PholioMockQuery to get there so as to not duplicate any business logic.

Test Plan: made a pholio mock with lots of inline comments. pre-patch "show older" fatals and post-patch "show older" works

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6770

Differential Revision: https://secure.phabricator.com/D11002

Details

Provenance
Bob TrahanAuthored on Dec 17 2014, 9:42 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPed4c7893e900: Fix a exception being thrown from Diviner
Branches
Unknown
Tags
Unknown

Event Timeline