HomePhorge
Diffusion Phorge f1c75a63823c

Allow construction of ApplicationSearch queries with GET
f1c75a63823c
Actions

Description

Allow construction of ApplicationSearch queries with GET

Summary:
Ref T3775 (discussion here). Ref T2625.

T3775 presents two problems:

  1. Existing tools which linked to /differential/active/epriestley/ (that is, put a username in the URL) can't generate search links now.
  2. Humans can't edit the URL anymore, either.

I think (1) is an actual issue, and this fixes it. I think (2) is pretty fluff, and this doesn't really try to fix it, although it probably improves it.

The fix for (1) is:

  • Provide a helper to read a parameter containing either a list of user PHIDs or a list of usernames, so /?users[]=PHID-USER-xyz (from a tokenizer) and /?users=alincoln,htaft (from an external program) are equivalent inputs.
  • Rename all the form parameters to be more digestable (authorPHIDs -> authors). Almost all of them were in this form already anyway. This just gives us ?users=alincoln instead of userPHIDs=alincoln.
  • Inside ApplicationSearch, if a request has no query associated with it but does have query parameters, build a query from the request instead of issuing the user's default query. Basically, this means that /differential/ runs the default query, while /differential/?users=x runs a custom query.

Test Plan: {F56612}

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2625, T3775

Differential Revision: https://secure.phabricator.com/D6840

Details

Provenance
epriestleyAuthored on Aug 29 2013, 11:52 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP5a11f08ba467: Use bar colors to show revision status in revision lists
Branches
master
Tags
None

Event Timeline

Changes (16)

PathSize
src/
aphront/
applications/
countdown/
query/
differential/
query/
feed/
query/
files/
query/
herald/
query/
legalpad/
query/
macro/
query/
paste/
query/
pholio/
query/
ponder/
query/
project/
query/
releeph/
query/
search/
controller/
engine/
slowvote/
query/

rPf1c75a63823c

View Options

src/aphront/AphrontRequest.php

Show First 20 Lines • Show All 162 Lines • ▼ Show 20 Lines final public function getExists($name) {
return array_key_exists($name, $this->requestData); return array_key_exists($name, $this->requestData);
} }
final public function getFileExists($name) { final public function getFileExists($name) {
return isset($_FILES[$name]) && return isset($_FILES[$name]) &&
(idx($_FILES[$name], 'error') !== UPLOAD_ERR_NO_FILE); (idx($_FILES[$name], 'error') !== UPLOAD_ERR_NO_FILE);
} }
final public function isHTTPGet() {
return ($_SERVER['REQUEST_METHOD'] == 'GET');
}
final public function isHTTPPost() { final public function isHTTPPost() {
return ($_SERVER['REQUEST_METHOD'] == 'POST'); return ($_SERVER['REQUEST_METHOD'] == 'POST');
} }
final public function isAjax() { final public function isAjax() {
return $this->getExists(self::TYPE_AJAX); return $this->getExists(self::TYPE_AJAX);
} }
▲ Show 20 Lines • Show All 232 Lines • ▼ Show 20 Lines/* -( Accessing Request Data )--------------------------------------------- */
* *
* @return dict<string, wild> Request data, with magic filtered out. * @return dict<string, wild> Request data, with magic filtered out.
*/ */
public function getPassthroughRequestData() { public function getPassthroughRequestData() {
$data = $this->getRequestData(); $data = $this->getRequestData();
// Remove magic parameters like __dialog__ and __ajax__. // Remove magic parameters like __dialog__ and __ajax__.
foreach ($data as $key => $value) { foreach ($data as $key => $value) {
if (strncmp($key, '__', 2)) { if (!strncmp($key, '__', 2)) {
unset($data[$key]); unset($data[$key]);
} }
} }
return $data; return $data;
} }
Show All 39 Lines
View Options

src/applications/countdown/query/PhabricatorCountdownSearchEngine.php

Loading...
View Options

src/applications/differential/query/DifferentialRevisionSearchEngine.php

Loading...
View Options

src/applications/feed/query/PhabricatorFeedSearchEngine.php

Loading...
View Options

src/applications/files/query/PhabricatorFileSearchEngine.php

Loading...
View Options

src/applications/herald/query/HeraldRuleSearchEngine.php

Loading...
View Options

src/applications/legalpad/query/LegalpadDocumentSearchEngine.php

Loading...
View Options

src/applications/macro/query/PhabricatorMacroSearchEngine.php

Loading...
View Options

src/applications/paste/query/PhabricatorPasteSearchEngine.php

Loading...
View Options

src/applications/pholio/query/PholioMockSearchEngine.php

Loading...
View Options

src/applications/ponder/query/PonderQuestionSearchEngine.php

Loading...
View Options

src/applications/project/query/PhabricatorProjectSearchEngine.php

Loading...
View Options

src/applications/releeph/query/ReleephRequestSearchEngine.php

Loading...
View Options

src/applications/search/controller/PhabricatorApplicationSearchController.php

Loading...
View Options

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

Loading...
View Options

src/applications/slowvote/query/PhabricatorSlowvoteSearchEngine.php

Loading...