HomePhorge

Fix existence test in "reconcile.php"

Description

Fix existence test in "reconcile.php"

Summary:
"rev-parse --verify" is actually a terrible test, it only survived my test cases
because I put garbage into the tables with RAND() or similar, not
properly-formatted garbage.

Use "cat-file -t" instead to ensure we perform an object-existence test.

Test Plan: Ran "reconcile.php P" locally, ran "cat-file -t" and "rev-parse
--verify" on properly-formatted but invalid hashes like
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa", worked with @rguerin to resolve
commit issues.

Reviewers: btrahan, rguerin

Reviewed By: rguerin

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1590

Details

Provenance
epriestleyAuthored on Feb 7 2012, 10:46 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP47631530a550: Remove admin requirement from MetaMTASendGridReceiveController
Branches
Loading...
Tags
Loading...

Event Timeline