HomePhorge

Prevent using deleted repositories when displaying commits for a revision.

Description

Prevent using deleted repositories when displaying commits for a revision.

Summary:
We deleted a repository (I don't remember which one). Some
differential revisions where committed to this repository, and opening
these revisions show a blank page, because the repository_id is not in
the database anymore.

This causes the 'ERROR 8: Undefined index: 12 at
[phabricator/src/applications/phid/handle/data/PhabricatorObjectHandleData.php:209]
' in our log.

Test Plan:
Opened a revision which where committed to multiple repositories including
the deleted one. Made sure that the page was rendered correctly and there
were no messages in the error log.

Reviewed By: epriestley
Reviewers: epriestley, jungejason
CC: aran, epriestley
Differential Revision: 598

Details

Provenance
tuomaspelkonenAuthored on Jul 6 2011, 8:42 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPf9599f44997b: Allow configuration of a task-creation email address
Branches
Unknown
Tags
Unknown

Event Timeline