HomePhorge

Prevent "Wait for Build Commits" from creating billions of logs

Description

Prevent "Wait for Build Commits" from creating billions of logs

Summary:
Resolves T5987. This build step was at some point converted to use yielding, which meant that whenever the build step executes it will create a new log. This checks to see if there is an existing log before creating a new one and uses that instead.

Long term we're going to need some way of attaching data to PhabricatorWorkerYieldException that can be read when the build step starts again; this will allow us to move more build steps off while (...) { ... sleep(X); } loops and onto yielding.

Test Plan: Tested locally.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley

Maniphest Tasks: T5987

Differential Revision: https://secure.phabricator.com/D10383

Details

Provenance
James RhodesAuthored on Aug 29 2014, 9:11 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPd1936711a077: Diffusion - replace last `hg manifest` call with `hg locate`
Branches
Unknown
Tags
Unknown

Event Timeline