HomePhorge

Give users an explicit error if they try to upload a too-large diff to…

Description

Give users an explicit error if they try to upload a too-large diff to Differential

Summary:
Ref T8612. If a change affects more than 10K paths + hunks, tell the user it's too big and don't bother trying to write it. We're mostly bounded by INSERTs here.

Also, fix an issue with file upload errors. The keys are real PHP constants, but were accidentally converted to strings in D12797, causing every error to show as "unknown error".

Test Plan: {F1057509}

Reviewers: joshuaspence

Reviewed By: joshuaspence

Maniphest Tasks: T8612

Differential Revision: https://secure.phabricator.com/D14977

Details

Provenance
epriestleyAuthored on Jan 8 2016, 6:44 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP2c293bdca88d: Fix a missed use of project icons in typehaeads
Branches
Unknown
Tags
Unknown

Event Timeline