HomePhorge

Fix "show raw file" showing wrong file

Description

Fix "show raw file" showing wrong file

Summary:
In a revision with multiple diffs like
https://secure.phabricator.com/D3168?vs=6094&id=6095
clicking "Show Raw File (Left)" while comparing diffs 1 and 2 brings up
the version from base, instead of from diff 1. This is because the hunks
are stored as diffs between base and diff X, and the raw file is
generated from the hunks. This introduces a hack which is probably not
actually correct but seems to work for the 90% case.

(The "Show Raw File (Right)" button was and remains correct.)

Test Plan: Click raw file buttons while comparing different diffs.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3169

Details

Provenance
Alan HuangAuthored on Aug 7 2012, 6:53 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP523cba5da4d4: Use Remarkup document link
Branches
Unknown
Tags
Unknown

Event Timeline