HomePhorge

Add abstract `getGroup()` method

Description

Add abstract getGroup() method

Summary: In D11722, a getGroup() method was added to all subclasses of PhabricatorApplicationConfigOptions, but no abstract method was added to the base class. This will fail if a custom *ConfigOptions class does not provide a getGroup() method, in which case $group->getGroup() (in PhabricatorConfigListController) will fatal.

Test Plan: N/A

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11756

Details

Provenance
Joshua SpenceAuthored on Feb 28 2015, 2:47 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPea337abafb67: Minor tidying of `lipsum generate` workflow
Branches
Loading...
Tags
Loading...

Event Timeline