HomePhorge

Don't fatal when viewing tags pointing at commits we haven't imported/parsed yet

Description

Don't fatal when viewing tags pointing at commits we haven't imported/parsed yet

Summary:
In Diffusion, the "Tags" view may read commits which haven't imported or parsed yet, and thus don't have loadable objects.

Most of this logic tests for if ($commit), but the author part did not. Instead, don't render author information if $commit is not present.

Test Plan:

  • Loaded tags view with commits present.
  • Faked $commit = null;, loaded tag view, got this instead of a fatal:

{F5068432}

Reviewers: chad, amckinley

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D18290

Details

Provenance
epriestleyAuthored on Jul 28 2017, 10:37 AM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rPd114bc4a19bd: Fix dark mode highlight in Timeline
Branches
Unknown
Tags
Unknown

Event Timeline