HomePhorge

Allow users to create buildables from diffs

Description

Allow users to create buildables from diffs

Summary:
Now that diffs have PHIDs we can create buildables for them.

This also adds buildable.diff in the variables list so the diff ID is available, and it also fixes the Cancel button on "Edit Plan" page so it redirects to the right place.

Test Plan: Created a buildable from a diff, ran a build plan against it that had echo ${buildable.diff} and got the right ID. Also tested the "Edit Plan" cancel redirect.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Maniphest Tasks: T1049

Differential Revision: https://secure.phabricator.com/D7546

Details

Provenance
James RhodesAuthored on Nov 9 2013, 3:08 PM
epriestleyCommitted on Nov 9 2013, 3:08 PM
themackabuPushed on Mar 25 2025, 8:07 PM
Parents
rP79ef667dfdc8: Render build status on revisions and commits
Branches
Unknown
Tags
Unknown

Event Timeline